From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA518C4332F for ; Fri, 9 Dec 2022 02:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W4izhXHYQ/WfP8uK7uOj9cy22nFVOKOMwim3YbZxyFk=; b=eGM4YCMJvV3Vef ddP2JBu2+hUK7UaKDmuQ04IV5W3phID1LcqylaIStlxTnGLymwYtk/FhXLBp7CLPG9HRvCiGR8unv y98sEIz+OHhLMfJdqmT5zWqKFm/++5Fv3dlYgtrwc1h0pMNbglPqYIXCB4qnwBMI0kGkFsmwIeSRU ZZbdHLPkrRqnXFwtjZQX4L6nhexDKMob7Pd4L/4mqE5mtY94ezXbDGp5rsSx+48Bf1WguJ6FJTiy4 1Ikh0YAhhxbyRvuB7BLqDKG5wS0BJWfBOb77RsnjmT+HeR3JR9FZ7is91lnbAUGkHLEcMJqkyNPVD ItaBL+komyaevVfdl+rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3T6q-0011vG-DW; Fri, 09 Dec 2022 02:27:32 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3T6m-0011VH-CA for linux-riscv@lists.infradead.org; Fri, 09 Dec 2022 02:27:30 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 2ED5F24DD6E; Fri, 9 Dec 2022 10:26:58 +0800 (CST) Received: from EXMBX173.cuchost.com (172.16.6.93) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 10:26:58 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX173.cuchost.com (172.16.6.93) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 10:26:56 +0800 Message-ID: <236b1b83-9bda-ac09-ea09-9701dccb4ac6@starfivetech.com> Date: Fri, 9 Dec 2022 10:26:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Content-Language: en-US To: Ben Dooks CC: , , , , "David S . Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20221201090242.2381-1-yanhong.wang@starfivetech.com> <20221201090242.2381-3-yanhong.wang@starfivetech.com> From: yanhong wang In-Reply-To: X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX173.cuchost.com (172.16.6.93) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_182728_715613_3DB29A56 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIyLzEyLzkgOTo1OSwgQmVuIERvb2tzIHdyb3RlOgo+IAo+IAo+IE9uIDIwMjItMTIt MDEgMDk6MDIsIFlhbmhvbmcgV2FuZyB3cm90ZToKPj4gQWRkICJzbnBzLGR3bWFjLTUuMjAiIGNv bXBhdGlibGUgc3RyaW5nIGZvciA1LjIwIHZlcnNpb24gdGhhdCBjYW4gYXZvaWQKPj4gdG8gZGVm aW5lIHNvbWUgcGxhdGZvcm0gZGF0YSBpbiB0aGUgZ2x1ZSBsYXllci4KPj4KPj4gU2lnbmVkLW9m Zi1ieTogRW1pbCBSZW5uZXIgQmVydGhpbmcgPGtlcm5lbEBlc21pbC5kaz4KPj4gU2lnbmVkLW9m Zi1ieTogWWFuaG9uZyBXYW5nIDx5YW5ob25nLndhbmdAc3RhcmZpdmV0ZWNoLmNvbT4KPj4gLS0t Cj4+IMKgZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX3BsYXRmb3Jt LmMgfCAzICsrLQo+PiDCoDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3Rt bWFjL3N0bW1hY19wbGF0Zm9ybS5jCj4+IGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9z dG1tYWMvc3RtbWFjX3BsYXRmb3JtLmMKPj4gaW5kZXggNTBmNmI0YTE0YmU0Li5jYzNiNzAxYWY4 MDIgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0 bW1hY19wbGF0Zm9ybS5jCj4+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3Rt bWFjL3N0bW1hY19wbGF0Zm9ybS5jCj4+IEBAIC01MTksNyArNTE5LDggQEAgc3RtbWFjX3Byb2Jl X2NvbmZpZ19kdChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlCj4+ICpwZGV2LCB1OCAqbWFjKQo+PiDC oMKgwqDCoCBpZiAob2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUobnAsICJzbnBzLGR3bWFjLTQuMDAi KSB8fAo+PiDCoMKgwqDCoMKgwqDCoMKgIG9mX2RldmljZV9pc19jb21wYXRpYmxlKG5wLCAic25w cyxkd21hYy00LjEwYSIpIHx8Cj4+IMKgwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBh dGlibGUobnAsICJzbnBzLGR3bWFjLTQuMjBhIikgfHwKPj4gLcKgwqDCoMKgwqDCoMKgIG9mX2Rl dmljZV9pc19jb21wYXRpYmxlKG5wLCAic25wcyxkd21hYy01LjEwYSIpKSB7Cj4+ICvCoMKgwqDC oMKgwqDCoCBvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShucCwgInNucHMsZHdtYWMtNS4xMGEiKSB8 fAo+PiArwqDCoMKgwqDCoMKgwqAgb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUobnAsICJzbnBzLGR3 bWFjLTUuMjAiKSkgewo+PiDCoMKgwqDCoMKgwqDCoMKgIHBsYXQtPmhhc19nbWFjNCA9IDE7Cj4+ IMKgwqDCoMKgwqDCoMKgwqAgcGxhdC0+aGFzX2dtYWMgPSAwOwo+PiDCoMKgwqDCoMKgwqDCoMKg IHBsYXQtPnBtdCA9IDE7Cj4gCj4gb3V0IG9mIGludGVyZXN0LCBpcyB0aGUgdmVyc2lvbiBvZiB0 aGUgaXAgYXV0b2RldGVjdGFibGUgeWV0Pwo+IGFsc28sIHdlIHdvdWxkIGJlIGJldHRlciBvZmYg aWYgaGF2aW5nIGFuIGlmICh2ZXJzaW9uID4gNCkgY2hlY2sgaWYgd2UgdXNlIHRoZSBzdGFuZGFy ZCBzbnBzIGlwIGJsb2NrIGNvZGUgaGVhZGVycwo+IAoKWWVzLCB0aGUgdmVyc2lvbiBvZiB0aGUg aXAgaXMgYXV0b2RldGVjdGFibGUuIEl0IGlzIGFsc28gcG9zc2libGUgdG8gdXNlIHRoZSBzdGFu ZGFyZCAic25wcywgZHdtYWMtNS4xMGEiIGRlZmluaXRpb24gb24gSkg3MTEw77yIaGFzIGJlZW4g dGVzdGVkIG9uIHRoZSBWaXNpb25GaXZlIHYyIGJvYXJkcyBhbmQgd29ya3Mgbm9ybWFsbHnvvIks IGRvIHlvdSBoYXZlIGFueSBiZXR0ZXIgc3VnZ2VzdGlvbnM/CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGlu dXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454E9C4332F for ; Fri, 9 Dec 2022 02:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbiLIC1H convert rfc822-to-8bit (ORCPT ); Thu, 8 Dec 2022 21:27:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbiLIC1H (ORCPT ); Thu, 8 Dec 2022 21:27:07 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD25E442FE; Thu, 8 Dec 2022 18:27:04 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 2ED5F24DD6E; Fri, 9 Dec 2022 10:26:58 +0800 (CST) Received: from EXMBX173.cuchost.com (172.16.6.93) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 10:26:58 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX173.cuchost.com (172.16.6.93) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 9 Dec 2022 10:26:56 +0800 Message-ID: <236b1b83-9bda-ac09-ea09-9701dccb4ac6@starfivetech.com> Date: Fri, 9 Dec 2022 10:26:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Content-Language: en-US To: Ben Dooks CC: , , , , "David S . Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20221201090242.2381-1-yanhong.wang@starfivetech.com> <20221201090242.2381-3-yanhong.wang@starfivetech.com> From: yanhong wang In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX173.cuchost.com (172.16.6.93) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/12/9 9:59, Ben Dooks wrote: > > > On 2022-12-01 09:02, Yanhong Wang wrote: >> Add "snps,dwmac-5.20" compatible string for 5.20 version that can avoid >> to define some platform data in the glue layer. >> >> Signed-off-by: Emil Renner Berthing >> Signed-off-by: Yanhong Wang >> --- >>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++- >>  1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> index 50f6b4a14be4..cc3b701af802 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> @@ -519,7 +519,8 @@ stmmac_probe_config_dt(struct platform_device >> *pdev, u8 *mac) >>      if (of_device_is_compatible(np, "snps,dwmac-4.00") || >>          of_device_is_compatible(np, "snps,dwmac-4.10a") || >>          of_device_is_compatible(np, "snps,dwmac-4.20a") || >> -        of_device_is_compatible(np, "snps,dwmac-5.10a")) { >> +        of_device_is_compatible(np, "snps,dwmac-5.10a") || >> +        of_device_is_compatible(np, "snps,dwmac-5.20")) { >>          plat->has_gmac4 = 1; >>          plat->has_gmac = 0; >>          plat->pmt = 1; > > out of interest, is the version of the ip autodetectable yet? > also, we would be better off if having an if (version > 4) check if we use the standard snps ip block code headers > Yes, the version of the ip is autodetectable. It is also possible to use the standard "snps, dwmac-5.10a" definition on JH7110（has been tested on the VisionFive v2 boards and works normally）, do you have any better suggestions?