From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Thu, 7 Dec 2017 08:14:50 -0500 (EST)
Subject: [Cluster-devel] [PATCH 1/3] gfs2: Add a next-resource-group
 pointer	to resource groups
In-Reply-To: <20171207115214.3726-2-anprice@redhat.com>
References: <20171207115214.3726-1-anprice@redhat.com>
	<20171207115214.3726-2-anprice@redhat.com>
Message-ID: <237145216.39445857.1512652490587.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

----- Original Message -----
| Add a new rg_skip field to struct gfs2_rgrp, replacing __pad. The
| -	str->__pad = cpu_to_be32(0);
| +	if (next != NULL && next->rd_addr > rgd->rd_addr)
| +		str->rg_skip = cpu_to_be32(next->rd_addr - rgd->rd_addr);

Without having looked at the original:

Shouldn't we still initialize it to 0 or put in an else clause?
I'm concerned that we might end up with an uninitialized random value
at the last rgrp (which may not be a big concern until gfs2_grow or
fsck time).

Bob Peterson
Red Hat File Systems