From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 1/2] regulator: gpio: Document regulator-type property
Date: Thu, 05 Dec 2013 21:08:59 +0100 [thread overview]
Message-ID: <2371962.Qn6eVMpFgi@avalon> (raw)
In-Reply-To: <1386270722-13962-1-git-send-email-broonie@kernel.org>
Hi Mark,
Thank you for the patch.
On Thursday 05 December 2013 19:12:01 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index
> 63c659800c03..aaf5f66e66fb 100644
> --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> @@ -10,6 +10,8 @@ Optional properties:
> - gpios : GPIO group used to control voltage.
> - startup-delay-us : Startup time in microseconds.
> - enable-active-high : Polarity of GPIO is active high (default is low).
> +- regulator-type : Specifies what is being regulated, must be either
> + "voltage" or "current"
What about adding "The type defaults to voltage if unspecified." ?
> Any property defined as part of the core regulator binding defined in
> regulator.txt can also be used.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-05 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:12 [PATCH 1/2] regulator: gpio: Document regulator-type property Mark Brown
2013-12-05 19:12 ` [PATCH 2/2] regulator: gpio: Warn if an invalid regulator-type is supplied Mark Brown
2013-12-05 20:10 ` Laurent Pinchart
2013-12-05 20:08 ` Laurent Pinchart [this message]
2013-12-05 20:42 ` [PATCH 1/2] regulator: gpio: Document regulator-type property Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2371962.Qn6eVMpFgi@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.