From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v8 8/9] eal: enable PCI bus Date: Wed, 18 Jan 2017 00:57:30 +0100 Message-ID: <2377627.GBliyb1Sy7@xps13> References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-9-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Shreyansh Jain Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 50166DE5 for ; Wed, 18 Jan 2017 00:57:32 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id r144so248552188wme.1 for ; Tue, 17 Jan 2017 15:57:32 -0800 (PST) In-Reply-To: <1484660264-6531-9-git-send-email-shreyansh.jain@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-17 19:07, Shreyansh Jain: > - /* Probe & Initialize PCI devices */ > - if (rte_eal_pci_probe()) > - rte_panic("Cannot probe PCI\n"); > - > /* Probe all the buses and devices/drivers on them */ > if (rte_bus_probe()) > rte_panic("Cannot probe devices\n"); > I like reading this :) It is a good step. A next step could be removing rte_bus_probe() and do it from the scan functions, after letting the application manage the blacklist via a callback.