From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25D3CC19F32 for ; Sun, 2 Mar 2025 04:09:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 214038058A; Sun, 2 Mar 2025 05:09:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=riseup.net header.i=@riseup.net header.b="rJzdr0Pd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8643B81101; Sun, 2 Mar 2025 05:09:55 +0100 (CET) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 67E57803CC for ; Sun, 2 Mar 2025 05:09:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=danct12@riseup.net Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4Z57kk0JxvzDqND; Sun, 2 Mar 2025 04:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1740888590; bh=vxQivG4u/E4gzxpA3kSPK5w3y95QuDbjUVP1Mnn8HOk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rJzdr0PdMKo8mQZTTv1fZ8Qh8Lp5ju4x9AN/BBF4sJQbIVDdRBUbBdXYtujdG+K5n qSp4JyFP0wuw2ay6vcc21wgpb0OOMwOhYnbiPW3hO0ld0w3ss54HWAVVT7bqn/ljMQ HVpILXMJwzsO07aWuL1EiZB+8GOn9jApSe/F7EDw= X-Riseup-User-ID: DA01CE96D00546C4C8272B721134457255F0B06CFE0693C9A66C09942B6D5640 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4Z57kd61zhzJrpw; Sun, 2 Mar 2025 04:09:45 +0000 (UTC) From: Dang Huynh To: Anatolij Gustschin , Simon Glass , Philipp Tomsich , Kever Yang , Tom Rini , Nicolas Frattaroli , Jonas Karlman , Ondrej Jirman , Dragan Simic , Svyatoslav Ryhel , u-boot@lists.denx.de Cc: u-boot@lists.denx.de, Chaoyi Chen Subject: Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support Date: Sun, 02 Mar 2025 11:09:34 +0700 Message-ID: <2377708.irdbgypaU6@melttower> In-Reply-To: <97d68df3-e6e3-4912-aab3-0ffe09c218e2@rock-chips.com> References: <20250223-vop2-pt2-v2-0-71350e482970@riseup.net> <20250223-vop2-pt2-v2-6-71350e482970@riseup.net> <97d68df3-e6e3-4912-aab3-0ffe09c218e2@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Chaoyi Chen, On Thursday, February 27, 2025 6:29:13=E2=80=AFAM UTC Chaoyi Chen wrote: >=20 > Could you use a naming prefix like "rkvop2" to explicitly indicate the > use of vop2, thereby distinguishing it from rk_vop.c? >=20 Yes. This will be in v3. > > + struct rk3568_vop_esmart *esmart =3D priv->regs +=20 VOP2_ESMART_OFFSET(0); >=20 > You are assuming that the RK356X is always used ESMART0, which generally > works. But considering > that there are multiple Video Ports and different Video Ports may have > different primary win, > selecting the appropriate win can simplifies the processing for U-Boot > to Kernel transitions in the future. >=20 > It's a good idea to implement the win selection as a configurable > parameter, or we can consider the > default win used for different Video Ports. ESMART0 is configured to the desired video port on U-Boot. VOP2 should be=20 reconfigured by Linux.