From: Roopa Prabhu <roopa@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
netdev@vger.kernel.org, outreachy@lists.linux.dev,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style
Date: Mon, 23 May 2022 17:10:07 -0700 [thread overview]
Message-ID: <237b793b-ab52-4ff8-a2a5-44923f79da40@nvidia.com> (raw)
In-Reply-To: <20220520174020.3cffce01@kernel.org>
On 5/20/22 17:40, Jakub Kicinski wrote:
> On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote:
>>> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>>> if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
>>> tb[NDA_PORT])) {
>>> NL_SET_ERR_MSG(extack,
>>> - "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>>> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>> it looks still off by a space.
>>
>>> return -EINVAL;
>>> }
>>
>> this closing brace should line up with the if
> Let me just fix this myself when applying... There were 3 separate
> postings of v2, and they weren't even identical :(
thanks Jakub,
Alaa, when you accidentally send the same patch multiple times, you can
reply on the list and leave a note to the maintainer on which ones to
ignore (lets add this to the outreachy kernel patch submission
instructions if not already there)
next prev parent reply other threads:[~2022-05-24 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 0:36 [PATCH net-next v2] net: vxlan: Fix kernel coding style Alaa Mohamed
2022-05-20 5:06 ` Roopa Prabhu
2022-05-21 0:40 ` Jakub Kicinski
2022-05-24 0:10 ` Roopa Prabhu [this message]
2022-05-21 0:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 0:24 Alaa Mohamed
2022-05-20 0:14 Alaa Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237b793b-ab52-4ff8-a2a5-44923f79da40@nvidia.com \
--to=roopa@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.