From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/2] mempool: allow for user-owned mempool caches Date: Tue, 19 Apr 2016 17:56:29 +0200 Message-ID: <2380816.EghbxR00Rr@xps13> References: <1459784610-14008-1-git-send-email-l@nofutznetworks.com> <2601191342CEEE43887BDE71AB97725836B3F4BA@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Ananyev, Konstantin" To: Lazaros Koromilas Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 3538F2C65 for ; Tue, 19 Apr 2016 17:56:33 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n3so37617361wmn.0 for ; Tue, 19 Apr 2016 08:56:33 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-19 18:39, Lazaros Koromilas: > >> Removes the API calls: > >> > >> rte_mempool_sp_put_bulk(mp, obj_table, n) > >> rte_mempool_sc_get_bulk(mp, obj_table, n) > >> rte_mempool_sp_put(mp, obj) > >> rte_mempool_sc_get(mp, obj) > > > > Hmm, shouldn't we deprecate it first for a release before removing completely? > > Let say for now you can just make them macros that calls the remaining functions or so. > > How do we mark the calls as deprecated? The librte_compat stuff don't > apply here as we don't have a different version of the same symbol or > something. Do I need to put them as a notice? Yes a notice and add __rte_deprecated.