From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, Paolo Valente <paolo.valente@linaro.org>
Subject: Re: [PATCH] bfq: Fix computation of shallow depth
Date: Tue, 5 Jan 2021 09:29:15 -0700 [thread overview]
Message-ID: <238318dd-9103-e4e4-d591-ef7212b86a48@kernel.dk> (raw)
In-Reply-To: <20210105162141.GA28898@quack2.suse.cz>
On 1/5/21 9:21 AM, Jan Kara wrote:
> On Thu 10-12-20 10:44:33, Jan Kara wrote:
>> BFQ computes number of tags it allows to be allocated for each request type
>> based on tag bitmap. However it uses 1 << bitmap.shift as number of
>> available tags which is wrong. 'shift' is just an internal bitmap value
>> containing logarithm of how many bits bitmap uses in each bitmap word.
>> Thus number of tags allowed for some request types can be far to low.
>> Use proper bitmap.depth which has the number of tags instead.
>>
>> Signed-off-by: Jan Kara <jack@suse.cz>
>
> Ping Jens? I think it has fallen through the cracks?
More like waiting for Paolo to take a look. Don't mind taking it, and
I'll do that now, but I do expect him to review any BFQ patches being
sent out.
--
Jens Axboe
next prev parent reply other threads:[~2021-01-05 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 9:44 [PATCH] bfq: Fix computation of shallow depth Jan Kara
2021-01-05 16:21 ` Jan Kara
2021-01-05 16:29 ` Jens Axboe [this message]
2021-01-06 17:02 ` Paolo Valente
2021-01-13 13:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238318dd-9103-e4e4-d591-ef7212b86a48@kernel.dk \
--to=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.