From: Thomas Monjalon <thomas@monjalon.net>
To: Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] doc: add new targets to "make help" output
Date: Fri, 04 Aug 2017 00:50:24 +0200 [thread overview]
Message-ID: <2383964.bQBCqqHOqo@xps> (raw)
In-Reply-To: <1499447399-9467-1-git-send-email-erik.g.carrillo@intel.com>
Hi,
Sorry for the very very late review.
07/07/2017 19:09, Gabriel Carrillo:
> Commit aafaea3d3b70 ("devtools: add tags
> and cscope index generation") introduced
> new make targets. This change updates the
> help target output to reflect the additions.
>
> Signed-off-by: Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> + tags|gtags T= generate tags/gtags for given targets (T=)
> + cscope T= generate cscope database for given targets (T=)
No need of T= in the first column.
It is specified only for install which has two different meanings
with and without T=.
You should also add etags I think.
next prev parent reply other threads:[~2017-08-03 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 21:43 [PATCH] doc: add new targets to "make help" output Gabriel Carrillo
2017-06-06 6:40 ` Thomas Monjalon
2017-06-06 16:42 ` [PATCH v2] " Gabriel Carrillo
2017-06-26 15:38 ` Mcnamara, John
2017-07-07 17:00 ` Carrillo, Erik G
2017-07-07 17:09 ` [PATCH v3] " Gabriel Carrillo
2017-08-03 22:50 ` Thomas Monjalon [this message]
2017-08-05 9:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2383964.bQBCqqHOqo@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.