From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width.
Date: Mon, 04 May 2015 19:31:30 +0200 [thread overview]
Message-ID: <2384804.XbcbTBBFP9@wuerfel> (raw)
In-Reply-To: <1430757092-15847-1-git-send-email-joakim.tjernlund@transmode.se>
On Monday 04 May 2015 18:31:31 Joakim Tjernlund wrote:
> @@ -252,6 +260,8 @@ static void esdhc_of_platform_init(struct sdhci_host *host)
>
> if (vvn > VENDOR_V_22)
> host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ;
> +
> + host->mmc->caps |= MMC_CAP_8_BIT_DATA;
> }
>
Shouldn't this check the "bus-width" property before setting the width?
There might be an eMMC or SDIO with 4-bit interface connected.
Arnd
next prev parent reply other threads:[~2015-05-04 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 16:31 [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width Joakim Tjernlund
2015-05-04 16:31 ` [PATCH 2/2] sdhci-of-esdhc: Pre divider starts at 1 Joakim Tjernlund
2015-05-04 17:31 ` Arnd Bergmann [this message]
2015-05-04 21:17 ` [PATCH 1/2] sdhci-of-esdhc: Support 8BIT bus width Joakim Tjernlund
2015-05-04 21:49 ` Joakim Tjernlund
2015-05-05 10:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2384804.XbcbTBBFP9@wuerfel \
--to=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.