From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 09/21] modetest: Allow specifying plane position Date: Thu, 28 Mar 2013 01:17:04 +0100 Message-ID: <2385820.cvOiZeusva@avalon> References: <1363704962-14077-1-git-send-email-laurent.pinchart@ideasonboard.com> <1363704962-14077-10-git-send-email-laurent.pinchart@ideasonboard.com> <20130327155720.GE4469@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 8730EE5EED for ; Wed, 27 Mar 2013 17:16:15 -0700 (PDT) In-Reply-To: <20130327155720.GE4469@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Ville, On Wednesday 27 March 2013 17:57:20 Ville Syrj=E4l=E4 wrote: > On Tue, Mar 19, 2013 at 03:55:50PM +0100, Laurent Pinchart wrote: > > Extend the -P option to allow specifying the plane x and y offsets. The > > position is optional, if not specified the plane will be positioned at > > the center of the screen as before. > > = > > Signed-off-by: Laurent Pinchart > > --- > > = > > tests/modetest/modetest.c | 72 ++++++++++++++++++++++++++++++++-------= --- > > 1 file changed, 57 insertions(+), 15 deletions(-) > > = > > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c > > index 7153a40..f95efe6 100644 > > --- a/tests/modetest/modetest.c > > +++ b/tests/modetest/modetest.c > > @@ -645,6 +645,7 @@ struct connector_arg { > > = > > struct plane_arg { > > uint32_t con_id; /* the id of connector to bind to */ > > + uint32_t x, y; > = > I'd like the coordinates to allow negative values too. I just posted my > latest version of the plane clipping patches. The main feature there is > to allow coordinates to be partially/fully offscreen and the driver will > clip then the plane to the screen dimensions. Hence negative coordinates > become somewhat useful. > = > And if you're looking into plane stuff in general, maybe you can review > my patches? The drm_rect utility functions should be useful for all > drivers that have to deal with movable or scalable planes. I'll try to, but I'm very busy nowadays with pinctrl patches :-/ > Now I'll see about trying this stuff out with my latest patches. -- = Regards, Laurent Pinchart