All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: alexander.deucher@amd.com, Prike.Liang@amd.com, sukhatri@amd.com,
	jesse.zhang@amd.com, amd-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>
Cc: Vock Natalie <natalie.vock@gmx.de>
Subject: Re: [PATCH 8/8] drm/amdgpu: restructure VM state machine v2
Date: Tue, 26 May 2026 12:11:59 +0200	[thread overview]
Message-ID: <2389346.vFx2qVVIhK@timur-max> (raw)
In-Reply-To: <34270690-46ec-4212-92a8-8c782ab644b6@amd.com>

On 2026. május 26., kedd 10:51:38 közép-európai nyári idő Christian König 
wrote:
> On 5/26/26 01:29, Timur Kristóf wrote:
> > On 2026. április 27., hétfő 20:27:23 közép-európai nyári idő Christian
> > König> 
> > wrote:
> >> Instead of coming up with more sophisticated names for states a VM BO
> >> can be in, group them by the type of BO first and then by the state.
> >> 
> >> So we end with BO type kernel, always_valid and individual and then
> >> states
> >> evicted, moved and idle.
> >> 
> >> Not much functional change, except that evicted_user is moved back
> >> together with the other BOs again which makes the handling in
> >> amdgpu_vm_validate() a bit more complex.
> >> 
> >> Also fixes a problem with user queues and amdgpu_vm_ready(). We didn't
> >> considered the VM ready when user BOs were not ideally placed, harmless
> >> performance impact for kernel queues but a complete show stopper for
> >> userqueues.
> >> 
> >> v2: fix a few typos in comments, rename the BO types to make them more
> >> 
> >>     descriptive, fix a couple of bugs found during testing
> >> 
> >> v3: squashed together with revert to old status lock handling, looks
> >> 
> >>     like the first patch still had some bug which this one here should
> >>     fix.
> >>     Fix a missing lock around debugfs printing.
> >> 
> >> Signed-off-by: Christian König <christian.koenig@amd.com>
> > 
> > Hi Christian,
> > 
> > This patch regresses GPU recovery.
> > (Tested on SI, haven't had time to test other GPUs yet.)
> > 
> > It hits the following warning:
> > WARNING: drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:635 at
> > amdgpu_vm_pde_update And then this error:
> > [drm:amdgpu_gem_va_update_vm [amdgpu]] *ERROR* Couldn't update BO_VA (-22)
> > 
> > Please fix.
> 
> Yeah that's a known issue. Fix is already pushed to amd-staging-drm-next.

Hi Christian,

Where is this fix? As far as I see "restructure VM state machine v2" is the top 
commit on amd-staging-drm-next right now.

Timur




  reply	other threads:[~2026-05-26 10:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 18:27 [PATCH 1/8] drm/amdgpu: nuke amdgpu_userq_fence_slab Christian König
2026-04-27 18:27 ` [PATCH 2/8] drm/amdgpu: remove deadlocks from amdgpu_userq_pre_reset Christian König
2026-04-28  6:51   ` Liang, Prike
2026-04-28  8:15     ` Khatri, Sunil
2026-04-27 18:27 ` [PATCH 3/8] drm/amdgpu: rework amdgpu_userq_signal_ioctl v2 Christian König
2026-04-28  8:49   ` Liang, Prike
2026-05-04 12:33     ` Christian König
2026-04-28  9:35   ` Khatri, Sunil
2026-05-04 12:37     ` Christian König
2026-04-27 18:27 ` [PATCH 4/8] drm/amdgpu: remove almost all calls to amdgpu_userq_detect_and_reset_queues Christian König
2026-04-28  9:37   ` Khatri, Sunil
2026-04-29  3:16   ` Liang, Prike
2026-04-27 18:27 ` [PATCH 5/8] drm/amdgpu: fix userq hang detection and reset Christian König
2026-04-29  8:30   ` Liang, Prike
2026-04-27 18:27 ` [PATCH 6/8] drm/amdgpu: rework userq reset work handling Christian König
2026-04-30  6:37   ` Liang, Prike
2026-04-27 18:27 ` [PATCH 7/8] drm/amdgpu: fix handling in amdgpu_userq_create Christian König
2026-04-28 11:26   ` Khatri, Sunil
2026-05-07  6:13   ` Liang, Prike
2026-04-27 18:27 ` [PATCH 8/8] drm/amdgpu: restructure VM state machine v2 Christian König
2026-04-28 12:20   ` Khatri, Sunil
2026-05-08  2:24   ` Liang, Prike
2026-05-08  8:21     ` Christian König
2026-05-25 23:29   ` Timur Kristóf
2026-05-26  8:51     ` Christian König
2026-05-26 10:11       ` Timur Kristóf [this message]
2026-05-26 10:44         ` Christian König
2026-04-28  6:15 ` [PATCH 1/8] drm/amdgpu: nuke amdgpu_userq_fence_slab Liang, Prike
2026-04-28  8:06   ` Christian König
2026-04-28  7:57 ` Khatri, Sunil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2389346.vFx2qVVIhK@timur-max \
    --to=timur.kristof@gmail.com \
    --cc=Prike.Liang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=jesse.zhang@amd.com \
    --cc=natalie.vock@gmx.de \
    --cc=sukhatri@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.