Re: [PATCH] btrfs: reorganize error handling in btrfs_tree_mod_log_insert_key

[Sun YangKai <sunk67188@gmail.com>]

> > -	ret = tree_mod_log_insert(eb->fs_info, tm);
> > -out_unlock:
> > +	/* Deal with allocation error. */
> > +	if (tm)
> > +		ret = tree_mod_log_insert(eb->fs_info, tm);
> 
> Sorry, I don't think this is really that better.
> 
> In fact I'm wondering why we don't delay the allocation after
> tree_mod_dont_log()?

That's what I want to do at first. However, after looking further into 
tree_mod_dont_log(), I found that it trys to get the tree_mod_log_lock. I'm 
not sure if it's better or worse to do the allocation things after getting the 
lock.

> 
> That would be way more straightforward.
> 
> Thanks,
> Qu
> 
> > +	else
> > +		ret = -ENOMEM;
> > +
> > 

Thanks,
Sun YangKai