From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay90-hz2.antispameurope.com (mx-relay90-hz2.antispameurope.com [94.100.136.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B2B201033 for ; Tue, 2 Dec 2025 11:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.136.190 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676147; cv=pass; b=XHdwA2EcINRkm7Q4pmIiagBqvx7a3cEnGunfifMtSi/Y6th1u9i8Q5NSNIS6VGJHppPdNSS4++WzkYirisHmUuHVv0fUfwpW55Ru3x/vh7rAaVVEhTmNtodekElywgEmltlbwEx05VNDqgAq29j/aqWZAxmRHrowWmqqRR3ehco= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764676147; c=relaxed/simple; bh=rOAoEjyVa1jEQA2BYDgvgv+WUqVYhkDMhJXVPZnWjU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K//MKLjETjzfieOs3XeRjt/qGwvk/+pGrbn+5aeBJBFaRpgSTtyhXDdXPTz8j3wwkODMSF5ToHAVZfiZnrlw7L9xgC35cPesfdxoEuOl8xfpcBDJbAHtHZGtpuHmY9UxG/HJB612/i2oHyTC9jnbvaQEwbRIRN7kPSEXb/N8xhk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=rWqjzDQ3; arc=pass smtp.client-ip=94.100.136.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="rWqjzDQ3" ARC-Authentication-Results: i=1; mx-gate90-hz2.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=smtp-out01-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=cPzBCQ/cVroc4yKwXafobMdff4xUZ/bh1Bgq00vprqk=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1764676105; b=Ybe1Ix3n0E9WnXDJJXFTcNiubbzuP1bbp9OriKXycZLCe7E/Ts4tdOZe+5wA6TiI4fLJXR5t zOd+SIEm73pxOFCkmRxTT1kaOQ2SOiLCmvqvM5A4JveuIAVFl8Pkap7lbl5cQrwAJkijW6GlPpA SVJSIv1HUTXdH4u34iNLlklseo9V5dGxHN0eYHOrN36MjSsybxkQJxcVRNiJIqIF9quZPbXS6wH 1ymO6MToMHXmfy8V69tA7LEEuLIKGOdXoATdfWJOuTC1Meto4CA3DoBqYq4pyw/xG4e9c6aG0u3 YyUiYixZEzR2RrLVaDbwaDaOVOGwbhUaEwNyKTuD8p4Jw== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1764676105; b=GWlfl+32EZS3bvlT1wMin0Z4bznOGwPOmUs6c5xMwPzVNCkxBGsy8a1xMFcnmQfyC5H677qa ng0Gv23IDe1JwuAXhME8M0y8mlKxMDsbjXx1WLETPVjUgNDwBwjmdx/IM/4kkKTd2PmaYmKEK+n 3JpKDIj+XJYZm4k0Xsp7wusyu/+J4M1ydIljNBpjHR9g/m2tLPBHku/KogO7uQyTjDBNcTkiOE2 7DpqRuE8JGZGdFG6SJKUeGKr99Skq9ehuqkyhyAoUvN7x7GUCd2ZJJz1fF2/Jy0fNIy5Ts00Hxr N6plB7t3w+witYvXB2uXEeRhvhD7dzmnsVuWcbjyA3l6A== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay90-hz2.antispameurope.com; Tue, 02 Dec 2025 12:48:25 +0100 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by smtp-out01-hz1.hornetsecurity.com (Postfix) with ESMTPSA id BAAF7A4128F; Tue, 2 Dec 2025 12:48:15 +0100 (CET) From: Alexander Stein To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, frank.li@nxp.com, Sherry Sun Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: imx8qm-ss-dma: correct the dma channels of lpuart Date: Tue, 02 Dec 2025 12:48:15 +0100 Message-ID: <2395053.ElGaqSPkdT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20251202111638.3553-1-sherry.sun@nxp.com> References: <20251202111638.3553-1-sherry.sun@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:imx@lists.linux.dev X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay90-hz2.antispameurope.com with 4dLJtm3MJzzWycw X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:199991314bca0e7504113f70cfa02bc4 X-cloud-security:scantime:1.766 DKIM-Signature: a=rsa-sha256; bh=cPzBCQ/cVroc4yKwXafobMdff4xUZ/bh1Bgq00vprqk=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1764676105; v=1; b=rWqjzDQ3CP5juZNzgJjXaKlKjrXLNCLMfNHieY90fsqHuuUpq4HYSVpYN5MhnhFMhzsV21fo LpvqEL390o5yx5LDmlCGJYpXY5LStOobSlOqQxIF4UIEVzseWxtPE9gONwAgN2++sRNjQO2SN3f OHe92YyZnZzjXVyHqqAol1QhSrkS1qbJ47QkGYMnIaytCo/lxzqfBBUmOBm2pk5aFNxPZiZgNYo 7JwxIvn7qTEJebESsmZuRYYz1qjNQGTShSkeeh4+GPV2oXAbjHeHx4Fx41d/x+B2BeUHCELNegh qR+U6jF9H6Cjvg8K9TBmXUUg1RrkNZg57CVXAlR3ji+kQ== Hi, Am Dienstag, 2. Dezember 2025, 12:16:38 CET schrieb Sherry Sun: > The commit 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel > order") swap uart rx and tx channel at common imx8-ss-dma.dtsi. But miss > update imx8qm-ss-dma.dtsi. >=20 > The commit 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart > dma-names") just simple add dma-names as binding doc requirement. >=20 > Correct lpuart0 - lpuart3 dma rx and tx channels, and use defines for > the FSL_EDMA_RX flag. >=20 > Fixes: 616effc0272b5 ("arm64: dts: imx8: Fix lpuart DMA channel order") I'm wondering if this is actually a fix for 5a8e9b022e569 ("arm64: dts: imx8qm-ss-dma: Pass lpuart dma-names") instead. 616effc0272b5 just focuses on the common parts. But I don't have a strong opinion here. Thanks and best regards, Alexander > Signed-off-by: Sherry Sun > --- > arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm6= 4/boot/dts/freescale/imx8qm-ss-dma.dtsi > index 5f24850bf322..974e193f8dcb 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi > @@ -172,25 +172,25 @@ &flexcan3 { > =20 > &lpuart0 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 13 0 0>, <&edma2 12 0 1>; > + dmas =3D <&edma2 12 0 FSL_EDMA_RX>, <&edma2 13 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart1 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 15 0 0>, <&edma2 14 0 1>; > + dmas =3D <&edma2 14 0 FSL_EDMA_RX>, <&edma2 15 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart2 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 17 0 0>, <&edma2 16 0 1>; > + dmas =3D <&edma2 16 0 FSL_EDMA_RX>, <&edma2 17 0 0>; > dma-names =3D "rx","tx"; > }; > =20 > &lpuart3 { > compatible =3D "fsl,imx8qm-lpuart", "fsl,imx8qxp-lpuart"; > - dmas =3D <&edma2 19 0 0>, <&edma2 18 0 1>; > + dmas =3D <&edma2 18 0 FSL_EDMA_RX>, <&edma2 19 0 0>; > dma-names =3D "rx","tx"; > }; > =20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/