From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms@verge.net.au>
Cc: Nguyen An Hoan <na-hoan@jinso.co.jp>,
broonie@kernel.org, linux-renesas-soc@vger.kernel.org,
geert+renesas@glider.be, magnus.damm@gmail.com,
kuninori.morimoto.gx@renesas.com,
yoshihiro.shimoda.uh@renesas.com, h-inayoshi@jinso.co.jp,
nv-dung@jinso.co.jp, cv-dong@jinso.co.jp
Subject: Re: [PATCH 1/2] arm64: dts: r8a77965: add FDP1 device nodes
Date: Tue, 28 Aug 2018 12:56:18 +0300 [thread overview]
Message-ID: <23995298.iSy7kN2eB8@avalon> (raw)
In-Reply-To: <20180827125704.jg4zuj2pfjykbcga@verge.net.au>
Hi Simon,
On Monday, 27 August 2018 15:57:05 EEST Simon Horman wrote:
> On Fri, Aug 24, 2018 at 11:45:52AM +0300, Laurent Pinchart wrote:
> > On Friday, 24 August 2018 07:52:28 EEST Nguyen An Hoan wrote:
> > > From: Hoan Nguyen An <na-hoan@jinso.co.jp>
> >
> > You're missing a commit message. I agree that for simple patches like this
> > one the subject line often contains enough information, but adding a
> > commit message is still a good practice that we try to enforce through
> > the kernel. For instance, looking at git history for r8a7796, you could
> > use
> >
> > "The r8a77965 has a single FDP1 instance."
> >
> > > Signed-off-by: Hoan Nguyen An <na-hoan@jinso.co.jp>
> >
> > Apart from that,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Simon, could you update the commit message when taking this patch in your
> > tree, to avoid the need for a v2 ?
>
> Yes, can do.
>
> Can I confirm that it is safe, from a regression point of view,
> to apply this patch without patch 2/2?
As far as I know it is safe, yes.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-08-28 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 4:52 [PATCH 0/2] Add support fdp1 device for Salvator-XS M3-N Nguyen An Hoan
2018-08-24 4:52 ` [PATCH 1/2] arm64: dts: r8a77965: add FDP1 device nodes Nguyen An Hoan
2018-08-24 8:45 ` Laurent Pinchart
2018-08-27 12:57 ` Simon Horman
2018-08-28 9:56 ` Laurent Pinchart [this message]
2018-09-12 10:24 ` Simon Horman
2018-09-03 1:12 ` [1/2] " Nguyen An Hoan
2018-08-24 4:52 ` [PATCH 2/2] clk: renesas: r8a77965: Add FDP clock Nguyen An Hoan
2018-08-24 8:54 ` Laurent Pinchart
2018-08-28 9:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23995298.iSy7kN2eB8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=cv-dong@jinso.co.jp \
--cc=geert+renesas@glider.be \
--cc=h-inayoshi@jinso.co.jp \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=na-hoan@jinso.co.jp \
--cc=nv-dung@jinso.co.jp \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.