From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev, cupertino.miranda@oracle.com
Subject: Re: [PATCH 3/4] selftests/bpf: impose global ordering for test decl_tags
Date: Thu, 26 Mar 2026 16:30:00 -0700 [thread overview]
Message-ID: <23a2ed0f2272f74bd7eed4720a2ee3b442ffe02f.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzaETjC-_mZ_rpDkbxnXXBZLvh74mzNE3oW_Ra-VgGMRyQ@mail.gmail.com>
On Thu, 2026-03-26 at 16:00 -0700, Andrii Nakryiko wrote:
[...]
> > > > +static void *realloc_or_free(void *ptr, size_t size)
> > >
> > > but why?... why invent a new realloc usage pattern just to save two
> > > lines of error handling code?
> >
> > Yes. We have this in verifier.c:realloc_array() and I like it.
> > Can through this one away if you don't like it.
>
> it just that you still have explicit free()s in that function for
> clean up, so this realloc_or_free stands out as a deviation for no
> good reason. So yeah, I don't think it's worth doing... but I'm also
> not going to fight it, it just caught my "traditionalist"'s eye ;)
I'll respin, no problem.
next prev parent reply other threads:[~2026-03-26 23:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 17:39 [PATCH 0/4] selftests/bpf: impose global ordering for test decl_tags Eduard Zingerman
2026-03-26 17:39 ` [PATCH 1/4] selftests/bpf: fix __jited_unpriv tag name Eduard Zingerman
2026-03-27 21:52 ` Ihor Solodrai
2026-03-26 17:39 ` [PATCH 2/4] selftests/bpf: make str_has_pfx return pointer past the prefix Eduard Zingerman
2026-03-27 21:54 ` Ihor Solodrai
2026-03-27 21:57 ` Eduard Zingerman
2026-03-30 15:32 ` Puranjay Mohan
2026-03-30 22:52 ` Eduard Zingerman
2026-03-26 17:39 ` [PATCH 3/4] selftests/bpf: impose global ordering for test decl_tags Eduard Zingerman
2026-03-26 22:47 ` Andrii Nakryiko
2026-03-26 22:51 ` Eduard Zingerman
2026-03-26 23:00 ` Andrii Nakryiko
2026-03-26 23:30 ` Eduard Zingerman [this message]
2026-03-27 22:00 ` Ihor Solodrai
2026-03-27 22:07 ` Eduard Zingerman
2026-03-30 15:30 ` Puranjay Mohan
2026-03-30 22:53 ` Eduard Zingerman
2026-03-30 15:36 ` Puranjay Mohan
2026-03-30 22:58 ` Eduard Zingerman
2026-03-26 17:39 ` [PATCH 4/4] selftests/bpf: inline TEST_TAG constants in test_loader.c Eduard Zingerman
2026-03-27 22:04 ` Ihor Solodrai
2026-03-26 22:28 ` [PATCH 0/4] selftests/bpf: impose global ordering for test decl_tags Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a2ed0f2272f74bd7eed4720a2ee3b442ffe02f.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.