From: Krzysztof Kozlowski <krzk@kernel.org>
To: Purva Yeshi <purvayeshi550@gmail.com>,
ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, vz@mleia.com, piotr.wojtaszczyk@timesys.com
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pwm: Convert lpc32xx-pwm.txt to YAML schema
Date: Tue, 11 Mar 2025 16:14:55 +0100 [thread overview]
Message-ID: <23a5d017-06e5-4f4d-a522-1f4beb7a1f32@kernel.org> (raw)
In-Reply-To: <47f6713b-b751-4791-9059-a128dd1fc71d@gmail.com>
On 11/03/2025 15:55, Purva Yeshi wrote:
>>>
>>> Define properties:
>>> Restrict `compatible` to `"nxp,lpc3220-pwm"` using `const`.
>>> Limit `reg` to `maxItems: 1` to ensure a single register range.
>>> Set `"#pwm-cells"` to `const: 3` for expected PWM cell properties.
>>>
>>> Mark `compatible` and `reg` as required properties.
>>
>> So it wasn't before? What are you implying here?
>
> The compatible and reg properties were already present in the .txt file,
> but in a different format. I initially kept the commit message for them
> but have now removed it.
What does it mean "different format"?
...
>>>
>>> create mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml
>>> new file mode 100644
>>> index 000000000..3e41cd291
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.yaml
>>> @@ -0,0 +1,45 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/pwm/nxp,lpc32xx-pwm.yaml#
>>
>> Filename matching compatible.
>
> In the lpc32xx-pwm.txt file, the compatible property was defined as
> "nxp,lpc3220-pwm", so I have kept it the same. To ensure consistency
> between the filename and compatible, should I rename the file to
> nxp,lpc3220-pwm.yaml?
Use whatever is there in the compatible property as the filename.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-03-11 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 12:57 [PATCH] dt-bindings: pwm: Convert lpc32xx-pwm.txt to YAML schema Purva Yeshi
2025-03-11 13:22 ` Krzysztof Kozlowski
2025-03-11 14:55 ` Purva Yeshi
2025-03-11 15:14 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a5d017-06e5-4f4d-a522-1f4beb7a1f32@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=purvayeshi550@gmail.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.