From: Jiri Slaby <jirislaby@kernel.org>
To: Haowen Bai <baihaowen@meizu.com>,
arnd@arndb.de, gregkh@linuxfoundation.org, dsterba@suse.com,
elder@linaro.org, jcmvbkbc@gmail.com, johan@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] tty: synclink_cs: Use bitwise instead of arithmetic operator for flags
Date: Mon, 21 Mar 2022 08:28:40 +0100 [thread overview]
Message-ID: <23d3debb-cb2c-903a-97bf-eaf3a8e5b69d@kernel.org> (raw)
In-Reply-To: <1647846757-946-1-git-send-email-baihaowen@meizu.com>
On 21. 03. 22, 8:12, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> V1 -> V2: fix title subject misspelling try -> tty.
>
> drivers/char/pcmcia/synclink_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
> // BIT7:parity error
> // BIT6:framing error
>
> - if (status & (BIT7 + BIT6)) {
> + if (status & (BIT7 | BIT6)) {
> if (status & BIT7)
> icount->parity++;
> else
--
js
next prev parent reply other threads:[~2022-03-21 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 7:12 [PATCH V2] tty: synclink_cs: Use bitwise instead of arithmetic operator for flags Haowen Bai
2022-03-21 7:28 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-21 6:13 [PATCH v2] " Haowen Bai
2022-03-21 6:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d3debb-cb2c-903a-97bf-eaf3a8e5b69d@kernel.org \
--to=jirislaby@kernel.org \
--cc=arnd@arndb.de \
--cc=baihaowen@meizu.com \
--cc=dsterba@suse.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.