Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask

["Di, ChenxuX" <chenxux.di@intel.com>]

Hi, jia

> -----Original Message-----
> From: Di, ChenxuX
> Sent: Wednesday, November 4, 2020 5:49 PM
> To: Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
> 
> Hi, Jia
> 
> > -----Original Message-----
> > From: Guo, Jia <jia.guo@intel.com>
> > Sent: Wednesday, November 4, 2020 5:41 PM
> > To: Di, ChenxuX <chenxux.di@intel.com>; dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>;
> > stable@dpdk.org
> > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
> >
> > Hi, chenxu
> >
> > > -----Original Message-----
> > > From: Chenxu Di <chenxux.di@intel.com>
> > > Sent: Wednesday, November 4, 2020 4:30 PM
> > > To: dev@dpdk.org
> > > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > > <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Di,
> > > ChenxuX <chenxux.di@intel.com>; stable@dpdk.org
> > > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
> > >
> > > The register of FDIR flex mask should not be set during flow validate.
> > > It should be set when flow create.
> > >
> > > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for
> > > FDIR")
> >
> > Seems that you move the place of flexible payload parsing from flow
> > validate to create, you delete something but miss some useless
> > parameter deleting, such as " off_arr/len_arr" etc in this [PATCH 1/2]
> > or [PATCH 2/3]. Please double check if anything related remove and if
> > you want you could merge into 1 remove patch if it could be.
> >
> 
> Got it, I will double check it.
> 

I have double checked the code and I think the other code and parameter in parse function are useful and necessary.
The array  off_arr and len_arr is used to store the info of RAW if there are two or more RAW in pattern.

And I will merge into one patch in next version.


> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> > > ---
> > >  drivers/net/i40e/i40e_ethdev.h |  1 +
> > >  drivers/net/i40e/i40e_fdir.c   | 94 ++++++++++++++++++++++++++++++++
> > >  drivers/net/i40e/i40e_flow.c   | 97 +---------------------------------
> > >  3 files changed, 97 insertions(+), 95 deletions(-)
> > >
> >
> > <...>