From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Jingoo Han <jg1.han@samsung.com>, Joe Perches <joe@perches.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/9] pwm: spear: Remove unnecessary OOM messages
Date: Wed, 05 Mar 2014 17:29:55 +0100 [thread overview]
Message-ID: <24037035.nXcZgi4Mc2@avalon> (raw)
In-Reply-To: <CAKohponXNmXPZP2Umz3BfRnXyOPX5Fa9606Lc42ORnOuevifEw@mail.gmail.com>
Hi Viresh,
On Thursday 06 March 2014 00:17:38 Viresh Kumar wrote:
> On 5 March 2014 19:00, Laurent Pinchart wrote:
> > Sure, but I wasn't sure whether all error code paths in kmalloc() resulted
> > in an OOM message. For instance, the following code path results in an
> > allocation failure but doesn't seem to print an OOM message:
> >
> > kmalloc
> > __kmalloc
> > __do_kmalloc
> > slab_alloc
> > slab_should_failslab
> > should_failslab
> > should_fail
> >
> > A bit far-fetched possibly as it requires fault injection. I haven't found
> > any other such code path, but my understanding of that code is a bit
> > limited.
>
> In that case should we actually accept patches like this at all? As they
> might be ending up removing some useful print messages?
Dan has pointed out that I've missed the fail_dump() call in should_fail().
One could argue that fail_dump() wouldn't print any message if the fault
injection framework has verbosity set to 0, but I suppose we can assume that
people using the fault injection framework know what they're doing.
All other error paths in kmalloc() seem to result in a message being printed.
I might have missed something, but I can trust the developers who know that
code much better than I do that kmalloc() is designed to print an error
message in all error paths. Any failure to print a message would be a
kmalloc() bug that should be fixed, and getting rid of the allocation error
messages in drivers would seem like a nice cleanup to me.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-05 16:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 0:59 [PATCH 0/9] pwm: Remove unnecessary OOM messages Jingoo Han
2014-02-26 1:02 ` [PATCH 1/9] pwm: ab8500: " Jingoo Han
2014-02-26 1:04 ` [PATCH 2/9] pwm: i.MX: " Jingoo Han
2014-02-26 1:06 ` [PATCH 3/9] pwm: pxa: " Jingoo Han
2014-02-26 1:08 ` [PATCH 4/9] pwm: renesas-tpu: " Jingoo Han
2014-02-26 2:22 ` Laurent Pinchart
2014-02-26 2:34 ` Jingoo Han
2014-02-26 22:02 ` Laurent Pinchart
2014-02-26 1:09 ` [PATCH 5/9] pwm: spear: " Jingoo Han
2014-02-26 4:49 ` Viresh Kumar
2014-02-26 4:57 ` Jingoo Han
2014-02-26 5:10 ` Viresh Kumar
2014-02-26 5:19 ` Joe Perches
2014-02-26 6:26 ` Viresh Kumar
2014-03-03 1:14 ` Jingoo Han
2014-03-03 9:53 ` Dan Carpenter
2014-03-05 11:00 ` Laurent Pinchart
2014-03-05 11:40 ` Dan Carpenter
2014-03-05 16:17 ` Viresh Kumar
2014-03-05 16:29 ` Laurent Pinchart [this message]
2014-03-07 8:04 ` Jingoo Han
2014-03-10 12:22 ` Thierry Reding
2014-04-03 3:24 ` Jingoo Han
2014-05-21 10:34 ` Thierry Reding
2014-02-26 1:10 ` [PATCH 6/9] pwm: tegra: " Jingoo Han
2014-02-26 1:12 ` [PATCH 7/9] pwm: pwm-tiecap: " Jingoo Han
2014-02-26 1:13 ` [PATCH 8/9] pwm: tiehrpwm: " Jingoo Han
2014-02-26 1:14 ` [PATCH 9/9] pwm: vt8500: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24037035.nXcZgi4Mc2@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.