From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] ixgbe: restore imissed stat counter
Date: Tue, 15 Dec 2015 18:06:24 +0100 [thread overview]
Message-ID: <2411343.XAzfyo3F5c@xps13> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA61283FE68@IRSMSX102.ger.corp.intel.com>
2015-12-15 16:41, Van Haaren, Harry:
> > From: Robin Jarry [mailto:robin.jarry@6wind.com]
> > Subject: [PATCH] ixgbe: restore imissed stat counter
> >
> > This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
> >
> > The ierrors counter still includes imissed for ixgbe. This behaviour is
> > not consistent amongst all drivers. Another patch may be needed to unify
> > the meaning of the ierrors counter.
> >
> > Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
> >
> > Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
>
> There is work to be done to allow easier distinction between
> drops due to the host, and errors due to bad packets.
>
> Until that work is done, write the dropped packet count to imissed, so:
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2015-12-15 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 16:05 [PATCH] ixgbe: restore imissed stat counter Robin Jarry
2015-12-15 16:41 ` Van Haaren, Harry
2015-12-15 17:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2411343.XAzfyo3F5c@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=robin.jarry@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.