From: Thomas Monjalon <thomas@monjalon.net>
To: matan@mellanox.com
Cc: dev@dpdk.org, gaetan.rivet@6wind.com,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] net/failsafe: fix FreeBSD build
Date: Tue, 13 Feb 2018 22:39:25 +0100 [thread overview]
Message-ID: <2411842.iNoccj3r1V@xps> (raw)
In-Reply-To: <20180213213312.22225-1-thomas@monjalon.net>
13/02/2018 22:33, Thomas Monjalon:
> The type pthread_t is not portable because it is freely defined.
> On Linux, it is an unsigned long int which can be printed with %l.
Forgot to add:
On FreeBSD, it is a pointer.
That's why there was this error:
drivers/net/failsafe/failsafe_private.h:377:53: error:
format specifies type 'unsigned long' but the argument has
type 'pthread_t' (aka 'struct pthread *')
Reported-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> The debug printing of the thread id is restricted to Linux only.
>
> Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2018-02-13 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 21:33 [PATCH] net/failsafe: fix FreeBSD build Thomas Monjalon
2018-02-13 21:39 ` Thomas Monjalon [this message]
2018-02-13 22:13 ` [PATCH v2] " Thomas Monjalon
2018-02-13 22:18 ` De Lara Guarch, Pablo
2018-02-13 22:19 ` Matan Azrad
2018-02-13 22:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2411842.iNoccj3r1V@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.