From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 3/5] drm/atomic: Add macros to access existing old/new state, v2. Date: Wed, 01 Mar 2017 02:56:59 +0200 Message-ID: <2414063.po5sNsMErD@avalon> References: <1487256430-7625-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487256430-7625-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1487256430-7625-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlbiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVGh1cnNkYXkgMTYgRmVi IDIwMTcgMTU6NDc6MDggTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gQWZ0ZXIgYXRvbWljIGNv bW1pdCwgdGhlc2UgbWFjcm9zIHNob3VsZCBiZSB1c2VkIGluIHBsYWNlIG9mCj4gZ2V0X2V4aXN0 aW5nX3N0YXRlLiBBbHNvIGFmdGVyIGNvbW1pdCBnZXRfeHhfc3RhdGUgc2hvdWxkIG5vIGxvbmdl cgo+IGJlIHVzZWQgYmVjYXVzZSBpdCBtYXkgbm90IGhhdmUgdGhlIHJlcXVpcmVkIGxvY2tzLgo+ IAo+IFRoZSBjYWxscyB0byBkcm1fYXRvbWljX2dldF9leGlzdGluZ18kb2JqX3N0YXRlIHNob3Vs ZCBubyBsb25nZXIgYmUKPiB1c2VkLCBhbmQgY29udmVydGVkIG92ZXIgdG8gdGhlc2UgbmV3IGNh bGxzLgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBFeHBhbmQgY29tbWl0IG1lc3NhZ2UuCj4g LSBEZXByZWNhdGUgZ2V0X2V4aXN0aW5nXypfc3RhdGUgZnVuY3Rpb25zIGluIHRoZSBkb2N1bWVu dGF0aW9uLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8 bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgaW5jbHVkZS9kcm0v ZHJtX2F0b21pYy5oIHwgMTA4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEwOCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+ IGluZGV4IGM2ZjM1NWE5NzBkMi4uMDE0N2EwNDc4NzhkIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUv ZHJtL2RybV9hdG9taWMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IEBAIC0y NzcsNiArMjc3LDkgQEAgaW50IGRybV9hdG9taWNfY29ubmVjdG9yX3NldF9wcm9wZXJ0eShzdHJ1 Y3QKPiBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsICoKPiAgICogVGhpcyBmdW5jdGlvbiByZXR1 cm5zIHRoZSBjcnRjIHN0YXRlIGZvciB0aGUgZ2l2ZW4gY3J0Yywgb3IgTlVMTAo+ICAgKiBpZiB0 aGUgY3J0YyBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4KPiArICoKPiAr ICogVGhpcyBmdW5jdGlvbiBpcyBkZXByZWNhdGVkLCBAZHJtX2F0b21pY19nZXRfb2xkX2NydGNf c3RhdGUgb3IKPiArICogQGRybV9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlIHNob3VsZCBiZSB1 c2VkIGluc3RlYWQuCj4gICAqLwo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fY3J0Y19zdGF0 ZSAqCj4gIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9t aWNfc3RhdGUgKnN0YXRlLAo+IEBAIC0yODYsMTIgKzI4OSw0NCBAQCBkcm1fYXRvbWljX2dldF9l eGlzdGluZ19jcnRjX3N0YXRlKHN0cnVjdAo+IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLCB9Cj4g Cj4gIC8qKgo+ICsgKiBkcm1fYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZSAtIGdldCBvbGQgY3J0 YyBzdGF0ZSwgaWYgaXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBv YmplY3QKPiArICogQGNydGM6IGNydGMgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9u IHJldHVybnMgdGhlIG9sZCBjcnRjIHN0YXRlIGZvciB0aGUgZ2l2ZW4gY3J0Yywgb3IKPiArICog TlVMTCBpZiB0aGUgY3J0YyBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4K PiArICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9jcnRjX3N0YXRlICoKPiArZHJtX2F0 b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICsJCQkgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gK3sKPiArCXJldHVybiBzdGF0ZS0+ Y3J0Y3NbZHJtX2NydGNfaW5kZXgoY3J0YyldLm9sZF9zdGF0ZTsKPiArfQo+ICsvKioKPiArICog ZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUgLSBnZXQgbmV3IGNydGMgc3RhdGUsIGlmIGl0 IGV4aXN0cwo+ICsgKiBAc3RhdGU6IGdsb2JhbCBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBj cnRjOiBjcnRjIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRoZSBu ZXcgY3J0YyBzdGF0ZSBmb3IgdGhlIGdpdmVuIGNydGMsIG9yCj4gKyAqIE5VTEwgaWYgdGhlIGNy dGMgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqLwo+ICtzdGF0 aWMgaW5saW5lIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqCj4gK2RybV9hdG9taWNfZ2V0X25ld19j cnRjX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJICAgICAgc3Ry dWN0IGRybV9jcnRjICpjcnRjKQo+ICt7Cj4gKwlyZXR1cm4gc3RhdGUtPmNydGNzW2RybV9jcnRj X2luZGV4KGNydGMpXS5uZXdfc3RhdGU7Cj4gK30KPiArCj4gKy8qKgo+ICAgKiBkcm1fYXRvbWlj X2dldF9leGlzdGluZ19wbGFuZV9zdGF0ZSAtIGdldCBwbGFuZSBzdGF0ZSwgaWYgaXQgZXhpc3Rz Cj4gICAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiAgICogQHBsYW5lOiBw bGFuZSB0byBncmFiCj4gICAqCj4gICAqIFRoaXMgZnVuY3Rpb24gcmV0dXJucyB0aGUgcGxhbmUg c3RhdGUgZm9yIHRoZSBnaXZlbiBwbGFuZSwgb3IgTlVMTAo+ICAgKiBpZiB0aGUgcGxhbmUgaXMg bm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqCj4gKyAqIFRoaXMgZnVu Y3Rpb24gaXMgZGVwcmVjYXRlZCwgQGRybV9hdG9taWNfZ2V0X29sZF9wbGFuZV9zdGF0ZSBvcgo+ ICsgKiBAZHJtX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0YXRlIHNob3VsZCBiZSB1c2VkIGluc3Rl YWQuCj4gICAqLwo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKgo+ICBk cm1fYXRvbWljX2dldF9leGlzdGluZ19wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUsCj4gQEAgLTMwMSwxMiArMzM2LDQ1IEBAIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5n X3BsYW5lX3N0YXRlKHN0cnVjdAo+IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLCB9Cj4gCj4gIC8q Kgo+ICsgKiBkcm1fYXRvbWljX2dldF9vbGRfcGxhbmVfc3RhdGUgLSBnZXQgcGxhbmUgc3RhdGUs IGlmIGl0IGV4aXN0cwo+ICsgKiBAc3RhdGU6IGdsb2JhbCBhdG9taWMgc3RhdGUgb2JqZWN0Cj4g KyAqIEBwbGFuZTogcGxhbmUgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVy bnMgdGhlIG9sZCBwbGFuZSBzdGF0ZSBmb3IgdGhlIGdpdmVuIHBsYW5lLCBvcgo+ICsgKiBOVUxM IGlmIHRoZSBwbGFuZSBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4KPiAr ICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqCj4gK2RybV9hdG9t aWNfZ2V0X29sZF9wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g KwkJCSAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPiArewo+ICsJcmV0dXJuIHN0YXRl LT5wbGFuZXNbZHJtX3BsYW5lX2luZGV4KHBsYW5lKV0ub2xkX3N0YXRlOwo+ICt9Cj4gKwo+ICsv KioKPiArICogZHJtX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0YXRlIC0gZ2V0IHBsYW5lIHN0YXRl LCBpZiBpdCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVjdAo+ ICsgKiBAcGxhbmU6IHBsYW5lIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiByZXR1 cm5zIHRoZSBuZXcgcGxhbmUgc3RhdGUgZm9yIHRoZSBnaXZlbiBwbGFuZSwgb3IKPiArICogTlVM TCBpZiB0aGUgcGxhbmUgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3RhdGUuCj4g KyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKgo+ICtkcm1fYXRv bWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ ICsJCQkgICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gK3sKPiArCXJldHVybiBzdGF0 ZS0+cGxhbmVzW2RybV9wbGFuZV9pbmRleChwbGFuZSldLm5ld19zdGF0ZTsKPiArfQo+ICsKPiAr LyoqCj4gICAqIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2Nvbm5lY3Rvcl9zdGF0ZSAtIGdldCBj b25uZWN0b3Igc3RhdGUsIGlmIGl0Cj4gZXhpc3RzICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0 YXRlIG9iamVjdAo+ICAgKiBAY29ubmVjdG9yOiBjb25uZWN0b3IgdG8gZ3JhYgo+ICAgKgo+ICAg KiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIGNvbm5lY3RvciBzdGF0ZSBmb3IgdGhlIGdpdmVu IGNvbm5lY3RvciwKPiAgICogb3IgTlVMTCBpZiB0aGUgY29ubmVjdG9yIGlzIG5vdCBwYXJ0IG9m IHRoZSBnbG9iYWwgYXRvbWljIHN0YXRlLgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIGlzIGRl cHJlY2F0ZWQsIEBkcm1fYXRvbWljX2dldF9vbGRfY29ubmVjdG9yX3N0YXRlIG9yCj4gKyAqIEBk cm1fYXRvbWljX2dldF9uZXdfY29ubmVjdG9yX3N0YXRlIHNob3VsZCBiZSB1c2VkIGluc3RlYWQu Cj4gICAqLwo+ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICoKPiAg ZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY29ubmVjdG9yX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZSwKPiBAQCAtMzIxLDYgKzM4OSw0NiBAQCBkcm1fYXRvbWljX2dldF9leGlz dGluZ19jb25uZWN0b3Jfc3RhdGUoc3RydWN0Cj4gZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsIH0K PiAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfZ2V0X29sZF9jb25uZWN0b3Jfc3RhdGUgLSBnZXQg Y29ubmVjdG9yIHN0YXRlLCBpZiBpdCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWlj IHN0YXRlIG9iamVjdAo+ICsgKiBAY29ubmVjdG9yOiBjb25uZWN0b3IgdG8gZ3JhYgo+ICsgKgo+ ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIG9sZCBjb25uZWN0b3Igc3RhdGUgZm9yIHRo ZSBnaXZlbiBjb25uZWN0b3IsCj4gKyAqIG9yIE5VTEwgaWYgdGhlIGNvbm5lY3RvciBpcyBub3Qg cGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUg c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9vbGRfY29ubmVj dG9yX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCSAgIHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gK3sKPiArCWludCBpbmRleCA9IGRybV9jb25u ZWN0b3JfaW5kZXgoY29ubmVjdG9yKTsKPiArCj4gKwlpZiAoaW5kZXggPj0gc3RhdGUtPm51bV9j b25uZWN0b3IpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJcmV0dXJuIHN0YXRlLT5jb25uZWN0 b3JzW2luZGV4XS5vbGRfc3RhdGU7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2dl dF9uZXdfY29ubmVjdG9yX3N0YXRlIC0gZ2V0IGNvbm5lY3RvciBzdGF0ZSwgaWYgaXQgZXhpc3Rz Cj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiArICogQGNvbm5lY3Rv cjogY29ubmVjdG9yIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRo ZSBuZXcgY29ubmVjdG9yIHN0YXRlIGZvciB0aGUgZ2l2ZW4gY29ubmVjdG9yLAo+ICsgKiBvciBO VUxMIGlmIHRoZSBjb25uZWN0b3IgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3Rh dGUuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICoK PiArZHJtX2F0b21pY19nZXRfbmV3X2Nvbm5lY3Rvcl9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUsCj4gKwkJCQkgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ ICt7Cj4gKwlpbnQgaW5kZXggPSBkcm1fY29ubmVjdG9yX2luZGV4KGNvbm5lY3Rvcik7Cj4gKwo+ ICsJaWYgKGluZGV4ID49IHN0YXRlLT5udW1fY29ubmVjdG9yKQo+ICsJCXJldHVybiBOVUxMOwo+ ICsKPiArCXJldHVybiBzdGF0ZS0+Y29ubmVjdG9yc1tpbmRleF0ubmV3X3N0YXRlOwo+ICt9Cj4g Kwo+ICsvKioKPiAgICogX19kcm1fYXRvbWljX2dldF9jdXJyZW50X3BsYW5lX3N0YXRlIC0gZ2V0 IGN1cnJlbnQgcGxhbmUgc3RhdGUKPiAgICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9i amVjdAo+ICAgKiBAcGxhbmU6IHBsYW5lIHRvIGdyYWIKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==