From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/6] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID Date: Thu, 19 Jan 2017 01:05:12 +0200 Message-ID: <2417180.haWkTHt9f8@avalon> References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> <1484614372-15342-6-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03ADA6E924 for ; Wed, 18 Jan 2017 23:04:54 +0000 (UTC) In-Reply-To: <1484614372-15342-6-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5IDE2IEphbiAyMDE3 IDE2OjUyOjUxIEpvaG4gU3R1bHR6IHdyb3RlOgo+IFRodXMgdGhpcyBwYXRjaCBjaGFuZ2VzIHRo ZSBFRElEIHByb2JpbmcgbG9naWMgc28gdGhhdCB3ZQo+IHJlLXVzZSB0aGUgX19hZHY3NTExX3Bv d2VyX29uL29mZigpIGNhbGxzIGluc3RlYWQgb2YgZHVwbGNpYXRpbmcKPiBsb2dpYy4KPiAKPiBU aGlzIGRvZXMgY2hhbmdlIGJlaGF2aW9yIHNsaWdodGx5IGFzIGl0IGFkZHMgdGhlIEhQRCBzaWdu YWwKPiBwdWxzZSB0byB0aGUgRURJRCBwcm9iZSBwYXRoLCBidXQgQXJjaGl0IGhhcyBoYWQgYSBw YXRjaCB0bwo+IGFkZCBIUEQgc2lnbmFsIHB1bHNlIHRvIHRoZSBFRElEIHByb2JlIHBhdGggYmVm b3JlLCBzbyB0aGlzCj4gc2hvdWxkIGFkZHJlc3MgdGhlIGNhc2VzIHdoZXJlIHRoYXQgaGVscGVk LgoKWW91IHNob3VsZCBhbHNvIG1lbnRpb25lZCB0aGF0IHRoZSBwb3dlciBvZmYgcGF0aCBub3cg Y2FsbHMgCnJlZ2NhY2hlX21hcmtfZGlydHkoKS4gQXBhcnQgZnJvbSB0aGF0LAoKUmV2aWV3ZWQt Ynk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogQXJjaGl0IFRhbmVq YSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4KPiBDYzogV29sZnJhbSBTYW5nIDx3c2ErcmVuZXNh c0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4KPiBDYzogTGFycy1QZXRlciBDbGF1c2VuIDxsYXJzQG1l dGFmb28uZGU+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNv bmJvYXJkLmNvbT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25l ZC1vZmYtYnk6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgo+IC0tLQo+IHY0 OiBSZXdvcmRlZCBjb21taXQgbWVzc2FnZSwgZm9jdXNpbmcgb24gcmUtdXNlIGFuZCBIUEQgcHVs c2UKPiAgICAgYmVoYXZpb3IgY2hhbmdlLgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdl L2Fkdjc1MTEvYWR2NzUxMV9kcnYuYyB8IDE3ICsrKy0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMgaW5kZXggMTJmMjg3Ni4uZDIx NmY2MQo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3 NTExX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFf ZHJ2LmMKPiBAQCAtNTczLDI0ICs1NzMsMTMgQEAgc3RhdGljIGludCBhZHY3NTExX2dldF9tb2Rl cyhzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSwKPiAgCXVuc2lnbmVkIGludCBjb3VudDsKPiAKPiAg CS8qIFJlYWRpbmcgdGhlIEVESUQgb25seSB3b3JrcyBpZiB0aGUgZGV2aWNlIGlzIHBvd2VyZWQg Ki8KPiAtCWlmICghYWR2NzUxMS0+cG93ZXJlZCkgewo+IC0JCXJlZ21hcF91cGRhdGVfYml0cyhh ZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX1BPV0VSLAo+IC0JCQkJICAgQURWNzUxMV9QT1dF Ul9QT1dFUl9ET1dOLCAwKTsKPiAtCQlpZiAoYWR2NzUxMS0+aTJjX21haW4tPmlycSkgewo+IC0J CQlyZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLCAKQURWNzUxMV9SRUdfSU5UX0VOQUJMRSgw KSwKPiAtCQkJCSAgICAgQURWNzUxMV9JTlQwX0VESURfUkVBRFkpOwo+IC0JCQlyZWdtYXBfd3Jp dGUoYWR2NzUxMS0+cmVnbWFwLCAKQURWNzUxMV9SRUdfSU5UX0VOQUJMRSgxKSwKPiAtCQkJCSAg ICAgQURWNzUxMV9JTlQxX0REQ19FUlJPUik7Cj4gLQkJfQo+IC0JCWFkdjc1MTEtPmN1cnJlbnRf ZWRpZF9zZWdtZW50ID0gLTE7Cj4gLQl9Cj4gKwlpZiAoIWFkdjc1MTEtPnBvd2VyZWQpCj4gKwkJ X19hZHY3NTExX3Bvd2VyX29uKGFkdjc1MTEpOwo+IAo+ICAJZWRpZCA9IGRybV9kb19nZXRfZWRp ZChjb25uZWN0b3IsIGFkdjc1MTFfZ2V0X2VkaWRfYmxvY2ssIGFkdjc1MTEpOwo+IAo+ICAJaWYg KCFhZHY3NTExLT5wb3dlcmVkKQo+IC0JCXJlZ21hcF91cGRhdGVfYml0cyhhZHY3NTExLT5yZWdt YXAsIEFEVjc1MTFfUkVHX1BPV0VSLAo+IC0JCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dO LAo+IC0JCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dOKTsKPiArCQlfX2Fkdjc1MTFfcG93 ZXJfb2ZmKGFkdjc1MTEpOwo+IAo+ICAJa2ZyZWUoYWR2NzUxMS0+ZWRpZCk7Cj4gIAlhZHY3NTEx LT5lZGlkID0gZWRpZDsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbdARXGf (ORCPT ); Wed, 18 Jan 2017 18:06:35 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:45618 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdARXG3 (ORCPT ); Wed, 18 Jan 2017 18:06:29 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 5/6] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID Date: Thu, 19 Jan 2017 01:05:12 +0200 Message-ID: <2417180.haWkTHt9f8@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1484614372-15342-6-git-send-email-john.stultz@linaro.org> References: <1484614372-15342-1-git-send-email-john.stultz@linaro.org> <1484614372-15342-6-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patch. On Monday 16 Jan 2017 16:52:51 John Stultz wrote: > Thus this patch changes the EDID probing logic so that we > re-use the __adv7511_power_on/off() calls instead of duplciating > logic. > > This does change behavior slightly as it adds the HPD signal > pulse to the EDID probe path, but Archit has had a patch to > add HPD signal pulse to the EDID probe path before, so this > should address the cases where that helped. You should also mentioned that the power off path now calls regcache_mark_dirty(). Apart from that, Reviewed-by: Laurent Pinchart > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz > --- > v4: Reworded commit message, focusing on re-use and HPD pulse > behavior change. > --- > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 12f2876..d216f61 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -573,24 +573,13 @@ static int adv7511_get_modes(struct adv7511 *adv7511, > unsigned int count; > > /* Reading the EDID only works if the device is powered */ > - if (!adv7511->powered) { > - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > - ADV7511_POWER_POWER_DOWN, 0); > - if (adv7511->i2c_main->irq) { > - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0), > - ADV7511_INT0_EDID_READY); > - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(1), > - ADV7511_INT1_DDC_ERROR); > - } > - adv7511->current_edid_segment = -1; > - } > + if (!adv7511->powered) > + __adv7511_power_on(adv7511); > > edid = drm_do_get_edid(connector, adv7511_get_edid_block, adv7511); > > if (!adv7511->powered) > - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > - ADV7511_POWER_POWER_DOWN, > - ADV7511_POWER_POWER_DOWN); > + __adv7511_power_off(adv7511); > > kfree(adv7511->edid); > adv7511->edid = edid; -- Regards, Laurent Pinchart