From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
Date: Fri, 19 Apr 2019 23:17:16 +0200 [thread overview]
Message-ID: <2420212.y2DT3RLapi@xps> (raw)
In-Reply-To: <20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com>
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> > nit: "test/compress:" for the title prefix ?
>
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.
In this case, you can just copy the prefix from the "Fixes:" line :)
> > On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> > <[1]bruce.richardson@intel.com> wrote:
> >
> > Build of test_compressdev.c fails on FreeBSD due to the missing
> > include of unistd.h, to provide the function usleep.
> > Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> > Cc: [2]pablo.de.lara.guarch@intel.com
> > Cc: [3]stable@dpdk.org
> > Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> >
> > Tested on FreeBSD 10.4.
> > Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
Applied, thanks
prev parent reply other threads:[~2019-04-19 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 12:03 [dpdk-dev] [PATCH] app/test: fix missing header Bruce Richardson
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-04-19 12:12 ` Bruce Richardson
2019-04-19 21:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2420212.y2DT3RLapi@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.