From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 10/11] net/failsafe: fix sub-device ownership
	race
Date: Wed, 09 May 2018 15:26:36 +0200
Message-ID: <24237723.mWpy8k2Fz7@xps>
References: <20180509094337.26112-1-thomas@monjalon.net>
 <20180509094337.26112-11-thomas@monjalon.net>
 <20180509124123.un67tmsh75kxwrir@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>, stable@dpdk.org
To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180509124123.un67tmsh75kxwrir@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/05/2018 14:41, Ga=EBtan Rivet:
> > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
>=20
> This fix is relying on the RTE_ETH_EVENT_NEW, an API that I think is not
> meant to be backported in the stable release that would be targetted by
> this commit id.

This event was added in 18.02. So yes it can be backported.

> I think this fix is useless without the rest of this series, so I don't
> know what is exactly planned about the rest (whether it is backported,
> and where), but I would only CC stable if this is planned, and only as
> soon as the relevant APIs are introduced.

All the series is candidate for 18.02 backport.


> >  static int
> >  fs_ethdev_portid_get(const char *name, uint16_t *port_id)
> >  {
> > -	uint16_t pid;
> > +	uint32_t pid;
>=20
> I do not see why the port_id is made uint32_t? Is there a reason?

Copying Matan's answer:
"
The maximum port id number can be 0xffff.
In this case the loop will be infinite if we use uint16 to iterate over all=
 the ports.
"