From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932583AbbJ0Ojj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 10:39:39 -0400
Received: from forward11h.cmail.yandex.net ([87.250.230.153]:60014 "EHLO
	forward11h.cmail.yandex.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S932502AbbJ0Ojh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 10:39:37 -0400
X-Greylist: delayed 537 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Oct 2015 10:39:37 EDT
From: Evgeniy Polyakov <zbr@ioremap.net>
Envelope-From: drustafa@yandex.ru
To: Jiri Kosina <jikos@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        GregKH <greg@kroah.com>
In-Reply-To: <alpine.LNX.2.00.1510261452080.8998@pobox.suse.cz>
References: <alpine.LNX.2.00.1510261452080.8998@pobox.suse.cz>
Subject: Re: [PATCH] w1: w1_process() is not freezable kthread
MIME-Version: 1.0
Message-Id: <2428911445956236@web17h.yandex.ru>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Tue, 27 Oct 2015 17:30:36 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

26.10.2015, 08:53, "Jiri Kosina" <jikos@kernel.org>:
> From: Jiri Kosina <jkosina@suse.cz>
>
> w1_process() calls try_to_freeze(), but the thread doesn't mark itself
> freezable through set_freezable(), so the try_to_freeze() call is useless.

I believe it is better to mark it freezable, what do you think?
Its task is useless if anyone else goes sleeping, it should freeze too.