All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@citrix.com>
To: "paul@xen.org" <paul@xen.org>
Cc: Igor Druzhinin <igor.druzhinin@citrix.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	'Paul Durrant' <xadimgnik@gmail.com>, "wl@xen.org" <wl@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [XEN PATCH for-4.14] tools/xen-ucode: fix error code propagation of microcode load operation
Date: Mon, 15 Jun 2020 12:13:38 +0100	[thread overview]
Message-ID: <24295.22498.780976.930384@mariner.uk.xensource.com> (raw)
In-Reply-To: <001001d640dc$db8704d0$92950e70$@xen.org>

Paul Durrant writes ("RE: [XEN PATCH for-4.14] tools/xen-ucode: fix error code propagation of microcode load operation"):
> > -----Original Message-----
> > From: Ian Jackson <ian.jackson@citrix.com>
> > Paul, would you Release-ack a patch that replaced every `return errno'
> > with (say) exit(12) ?
> 
> Why 12?

I tend to use 12 to mean `things went wrong'.  1 is a poor choice for
this because you want to use smaller numbers for less severe errors
and you want some space for things like "everything went OK but the
thing you asked me to delete already didn't exist" or "I compared
these files like you asked, and they are different".

> >  Otherwise, fixing this program not to try to
> > fit errno into an exit status is future work.  Also I notice that the
> > program exits 0 if invoked wrongly.  Unhelpful!  I would want to fix
> > that too.
> 
> Agreed that is unhelpful. I'm happy in principle to release-ack
> something replacing the returns with exits.

Thanks,
Ian.


  reply	other threads:[~2020-06-15 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 16:44 [PATCH] tools/xen-ucode: fix error code propagation of microcode load operation Igor Druzhinin
2020-06-12 16:53 ` [XEN PATCH for-4.14] " Ian Jackson
2020-06-12 17:13   ` Paul Durrant
2020-06-15 11:13     ` Ian Jackson [this message]
2020-06-12 17:16   ` Igor Druzhinin
2020-06-15 11:17     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24295.22498.780976.930384@mariner.uk.xensource.com \
    --to=ian.jackson@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=igor.druzhinin@citrix.com \
    --cc=paul@xen.org \
    --cc=wl@xen.org \
    --cc=xadimgnik@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.