From: Erikas Bitovtas <xerikasxx@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P
Date: Wed, 11 Feb 2026 15:32:41 +0200 [thread overview]
Message-ID: <242d5502-bf58-4e25-8258-8a6c75ff3623@gmail.com> (raw)
In-Reply-To: <6f97c68d-0236-4d04-8199-768ecee7c4dd@kernel.org>
>>>
>>> Please implement previous feedback.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Since I am making changes to the existing driver instead of creating a new one,
>> I introduced a new patch series. As I mentioned in the cover letter, cm36686 is
>> fully compatible with vcnl4040, so instead of creating a new binding, I create a
>> fallback compatible for the device. I probably should have named this patch
>> series something else.
>
> That's fine, but that's v3 of previous patches. Your work was to add
> CM36686 support. How you do it, evolves, but patchset/work is one
> continuous work. When you rework approach next time, you also start from
> v1? And then you go back to previous solution of new driver it will jump
> from v1 to v3?
>
There has been a misunderstanding. I assumed that since I will no longer
be developing that driver, this warrants a new patch series. I apologize
for this.
Here is the changelog since v2:
- Remove the previous unnecessary proposed driver and bindings.
- Add a fallback compatible for cm36686 of vcnl4040.
- Add a new compatible for cm36672p.
- Add channel info for cm36672p.
- Remove redundant information in the dt-bindings commit message.
Here is the link to v2:
https://lore.kernel.org/linux-iio/20260209182432.00006c3c@huawei.com/
I have received some feedback regarding the changes I made to the
existing vcnl4000 driver. Shall I submit the implementation of it as a
v3 to that series of patches?
next prev parent reply other threads:[~2026-02-11 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 20:46 [PATCH 0/2] iio: light: vcnl4000: Add support for Capella CM36686 and CM36672P Erikas Bitovtas
2026-02-10 20:46 ` [PATCH 1/2] dt-bindings: iio: light: vcnl4000: add " Erikas Bitovtas
2026-02-11 6:49 ` Krzysztof Kozlowski
2026-02-11 10:07 ` Erikas Bitovtas
2026-02-11 10:10 ` Krzysztof Kozlowski
2026-02-11 13:32 ` Erikas Bitovtas [this message]
2026-02-11 13:37 ` Andy Shevchenko
2026-02-11 13:44 ` Erikas Bitovtas
2026-02-11 13:59 ` Andy Shevchenko
2026-02-10 20:46 ` [PATCH 2/2] iio: light: vcnl4000: add support for " Erikas Bitovtas
2026-02-10 20:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=242d5502-bf58-4e25-8258-8a6c75ff3623@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.