From: Jay Vosburgh <fubar@us.ibm.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
bonding-devel@lists.sourceforge.net
Subject: Re: [Bonding-devel] [PATCH net-next] bonding: make release_and_destroy static
Date: Fri, 15 Oct 2010 16:16:33 -0700 [thread overview]
Message-ID: <24308.1287184593@death> (raw)
In-Reply-To: <20101015153725.GC7497@gospo.rdu.redhat.com>
Andy Gospodarek <andy@greyhouse.net> wrote:
>On Fri, Oct 15, 2010 at 08:09:34AM -0700, Stephen Hemminger wrote:
>> Only used in main file.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> --- a/drivers/net/bonding/bond_main.c 2010-10-15 08:07:14.163898236 -0700
>> +++ b/drivers/net/bonding/bond_main.c 2010-10-15 08:07:31.956373660 -0700
>> @@ -2057,8 +2057,8 @@ int bond_release(struct net_device *bond
>> * First release a slave and than destroy the bond if no more slaves are left.
>> * Must be under rtnl_lock when this function is called.
>> */
>> -int bond_release_and_destroy(struct net_device *bond_dev,
>> - struct net_device *slave_dev)
>> +static int bond_release_and_destroy(struct net_device *bond_dev,
>> + struct net_device *slave_dev)
>> {
>> struct bonding *bond = netdev_priv(bond_dev);
>> int ret;
>> --- a/drivers/net/bonding/bonding.h 2010-10-15 08:07:14.179898632 -0700
>> +++ b/drivers/net/bonding/bonding.h 2010-10-15 08:07:31.956373660 -0700
>> @@ -334,7 +334,6 @@ static inline void bond_unset_master_alb
>> struct vlan_entry *bond_next_vlan(struct bonding *bond, struct vlan_entry *curr);
>> int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, struct net_device *slave_dev);
>> int bond_create(struct net *net, const char *name);
>> -int bond_release_and_destroy(struct net_device *bond_dev, struct net_device *slave_dev);
>> int bond_create_sysfs(void);
>> void bond_destroy_sysfs(void);
>> void bond_prepare_sysfs_group(struct bonding *bond);
>
>Seems fine.
>
>Acked-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2010-10-15 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:09 [PATCH net-next] bonding: make release_and_destroy static Stephen Hemminger
2010-10-15 15:37 ` Andy Gospodarek
2010-10-15 23:16 ` Jay Vosburgh [this message]
2010-10-21 10:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24308.1287184593@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.