From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 29 Jan 2018 11:58:00 +0200 Subject: [PATCH] drm/bridge: Rename argument from crtc to bridge In-Reply-To: <20180129095531.4557-1-linus.walleij@linaro.org> References: <20180129095531.4557-1-linus.walleij@linaro.org> Message-ID: <2430917.BY1P9l4EpX@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Linus, Thank you for the patch. On Monday, 29 January 2018 11:55:31 EET Linus Walleij wrote: > Why is the argument to ->mode_valid() called "crtc"? > I guess a copy/paste error. Fix it. I confirm it's a mistake, so you can probably replace "guess" with a word carrying a bit more confidence :) > Signed-off-by: Linus Walleij Reviewed-by: Laurent Pinchart > --- > include/drm/drm_bridge.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index bb7b97dfb93e..3270fec46979 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -91,7 +91,7 @@ struct drm_bridge_funcs { > * > * drm_mode_status Enum > */ > - enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc, > + enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge, > const struct drm_display_mode *mode); > > /** -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge: Rename argument from crtc to bridge Date: Mon, 29 Jan 2018 11:58:00 +0200 Message-ID: <2430917.BY1P9l4EpX@avalon> References: <20180129095531.4557-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD8976E295 for ; Mon, 29 Jan 2018 09:57:46 +0000 (UTC) In-Reply-To: <20180129095531.4557-1-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTGludXMsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIE1vbmRheSwgMjkgSmFudWFy eSAyMDE4IDExOjU1OjMxIEVFVCBMaW51cyBXYWxsZWlqIHdyb3RlOgo+IFdoeSBpcyB0aGUgYXJn dW1lbnQgdG8gLT5tb2RlX3ZhbGlkKCkgY2FsbGVkICJjcnRjIj8KPiBJIGd1ZXNzIGEgY29weS9w YXN0ZSBlcnJvci4gRml4IGl0LgoKSSBjb25maXJtIGl0J3MgYSBtaXN0YWtlLCBzbyB5b3UgY2Fu IHByb2JhYmx5IHJlcGxhY2UgImd1ZXNzIiB3aXRoIGEgd29yZCAKY2FycnlpbmcgYSBiaXQgbW9y ZSBjb25maWRlbmNlIDopCgo+IFNpZ25lZC1vZmYtYnk6IExpbnVzIFdhbGxlaWogPGxpbnVzLndh bGxlaWpAbGluYXJvLm9yZz4KClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBpbmNsdWRlL2RybS9kcm1fYnJp ZGdlLmggfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQo+IAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fYnJpZGdlLmggYi9pbmNsdWRl L2RybS9kcm1fYnJpZGdlLmgKPiBpbmRleCBiYjdiOTdkZmI5M2UuLjMyNzBmZWM0Njk3OSAxMDA2 NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fYnJpZGdlLmgKPiArKysgYi9pbmNsdWRlL2RybS9k cm1fYnJpZGdlLmgKPiBAQCAtOTEsNyArOTEsNyBAQCBzdHJ1Y3QgZHJtX2JyaWRnZV9mdW5jcyB7 Cj4gIAkgKgo+ICAJICogZHJtX21vZGVfc3RhdHVzIEVudW0KPiAgCSAqLwo+IC0JZW51bSBkcm1f bW9kZV9zdGF0dXMgKCptb2RlX3ZhbGlkKShzdHJ1Y3QgZHJtX2JyaWRnZSAqY3J0YywKPiArCWVu dW0gZHJtX21vZGVfc3RhdHVzICgqbW9kZV92YWxpZCkoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRn ZSwKPiAgCQkJCQkgICBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSk7Cj4gCj4g IAkvKioKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==