From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: omapdrm: Use sizeof(*var) instead of sizeof(type) for structures
Date: Tue, 13 Dec 2016 23:26:19 +0200 [thread overview]
Message-ID: <2432832.BJReJvhKQp@avalon> (raw)
In-Reply-To: <20161213211212.rgy42u2izqttnype@phenom.ffwll.local>
On Tuesday 13 Dec 2016 22:12:12 Daniel Vetter wrote:
> On Tue, Dec 13, 2016 at 05:21:42PM +0200, Laurent Pinchart wrote:
> > By linking the sizeof to a variable type the code will be less prone to
> > bugs due to future type changes of variables.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Isn't there some cocci magic that does this for you?
There should be, but as it was only a handful of calls (well, for anyone who
has a hand with 7 fingers) I was done before I thought I could use coccinelle.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-13 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 15:21 [PATCH 0/2] omapdrm: Remove .load/.unload midlayer Laurent Pinchart
2016-12-13 15:21 ` [PATCH 1/2] drm: omapdrm: Use sizeof(*var) instead of sizeof(type) for structures Laurent Pinchart
2016-12-13 21:12 ` Daniel Vetter
2016-12-13 21:26 ` Laurent Pinchart [this message]
2016-12-13 15:21 ` [PATCH 2/2] drm: omapdrm: Perform initialization/cleanup at probe/remove time Laurent Pinchart
2016-12-13 21:21 ` Daniel Vetter
2016-12-13 21:41 ` Laurent Pinchart
2016-12-13 21:48 ` Daniel Vetter
2016-12-13 22:31 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2432832.BJReJvhKQp@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.