From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5 05/21] i40e: implement operations
	to	add/delete flow director
Date: Thu, 13 Nov 2014 10:50:20 +0100
Message-ID: <2433359.CatIjmm0iz@xps13>
References: <1413939687-11177-1-git-send-email-jingjing.wu@intel.com>
 <1414654006-7472-6-git-send-email-jingjing.wu@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8972683387D@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Wu, Jingjing" <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8972683387D-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Jingjing,

You didn't reply to Pablo's comment.
Any news of this patchset? Could it be reviewed?

Thanks
-- 
Thomas

2014-11-05 21:18, De Lara Guarch, Pablo:
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Jingjing Wu
> > Deal with two operations for flow director
> >  - RTE_ETH_FILTER_ADD
> >  - RTE_ETH_FILTER_DELETE
> > Encode the flow inputs to programming packet.
> > Sent the packet to filter programming queue and check status
> > on the status report queue.
> > 
> > Signed-off-by: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> >  lib/librte_pmd_i40e/i40e_ethdev.c |   3 +
> >  lib/librte_pmd_i40e/i40e_ethdev.h |   3 +
> >  lib/librte_pmd_i40e/i40e_fdir.c   | 622
> > ++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 628 insertions(+)
> > 
> > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> > b/lib/librte_pmd_i40e/i40e_ethdev.c
> > index 8195e8a..fb43efb 100644
> > --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> > @@ -4577,6 +4577,7 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev,
> >  		     enum rte_filter_op filter_op,
> >  		     void *arg)
> >  {
> > +	struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data-
> > >dev_private);
> >  	int ret = 0;
> > 
> >  	if (dev == NULL)
> > @@ -4585,6 +4586,8 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev,
> >  	switch (filter_type) {
> >  	case RTE_ETH_FILTER_TUNNEL:
> >  		ret = i40e_tunnel_filter_handle(dev, filter_op, arg);
> 
> Missing break here?
> 
> > +	case RTE_ETH_FILTER_FDIR:
> > +		ret = i40e_fdir_ctrl_func(pf, filter_op, arg);
> >  		break;
> >  	default:
> >  		PMD_DRV_LOG(WARNING, "Filter type (%d) not
> > supported",