Re: [PATCH v6 00/17] Modify code as suggested by the maintainer.

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/8/2024 12:11 PM, Howard Wang wrote:
> Remove some headers and code that are not used.
> Improve r8169.ini and r8169.rst gradually.
> 
> Howard Wang (17):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for hw config
>   net/r8169: add phy registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for phy configuration
>   net/r8169: add support for hw initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting fw version
>   net/r8169: add driver_start and driver_stop
>

Hi Howard,

Thanks for the updates.

Series should build after each patch, but it seems broken in the set,
starting from patch 4/17 there are some warnings, and they are fixed
after a few patches. But can you please sure it builds fine after each
patch?

Above build issue is the main blocker for the set, but there are a few
minor issues listed below:

1. please fix issue highlighted by check-git-log.sh
`./devtools/check-git-log.sh -n17`

2. Please fix meson syntax warnings
`./devtools/check-meson.py`


Also I put some comments to individual patches.