From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dL4jn-0004sU-To for mharc-grub-devel@gnu.org; Wed, 14 Jun 2017 05:37:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dL4jl-0004i3-6f for grub-devel@gnu.org; Wed, 14 Jun 2017 05:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dL4ji-0001OD-4l for grub-devel@gnu.org; Wed, 14 Jun 2017 05:37:17 -0400 Received: from mout.gmx.net ([212.227.17.22]:53676) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dL4jh-0001MC-Q4 for grub-devel@gnu.org; Wed, 14 Jun 2017 05:37:14 -0400 Received: from scdbackup.webframe.org ([87.167.207.232]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M8IuM-1dhqQ03urq-00vylu for ; Wed, 14 Jun 2017 11:37:11 +0200 Date: Wed, 14 Jun 2017 11:37:11 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: grub-mkrescue reacts vaguely on xorriso problems Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <24380769927419764858@scdbackup.webframe.org> X-Provags-ID: V03:K0:sM7xI/5Z1GxiA2ZlZ1U1FCvCNkTKjMIwrJSfNGEnFDw+8exmaaB hJe9Nr7fyJFHckT5SFP5pGzp6dY+dDB9zBVPS62ZkL/eLDLgO/SBa/XnOAiZLYBEm3jMG6u cvUvGKysulQ54sxbTbKorsLg5DTLa7074AOYdT/KMAmJtI4JrhNIo3ysOwsboXcUnVa8KON Ur7iKcuF5yRtauwR6slSA== X-UI-Out-Filterresults: notjunk:1;V01:K0:4czE4Pba1dc=:oktfJjGcAcscJZYsqZVjwq s2LTZltLOcUZWEOv/1RpKZbhVQWZTur9WLfgyavZ000Vcfj5YXJyvWNplq1IBQSelCmwPdMRY bxdqsOw7PZ6O2D8OHrHvyIWuoT5E0Q4aQ0A9/zasIzBNLSq56sK92M/LSJUWv3VlFXJcb2SDN iEiGntRZ2MOYSATxMJZIXH2Vu3MR03I7gL/FDX1aDNk7QE06XGRyf8b2z6uFZs4EVPKahraRk nWRhiVE/SGBnS5YopaWCfZo+wB8zl74pmVYLxlwSz7qcIQZzmeejAvpfSbAlqhsHFX0k5LtMK sN5Ej64H3fhtejdwJr6bmFpgFnoOP2swWPfmAWzJ3HVpILm1gRDL7PjzG7Je+DQsbL0F3JK0n VLy0z7q0Ao/XyfL2Xnd9QR4TwScspXaCES1Ztqb87/J9BQHH2AZwP36Rqib1Gp8AjImGHT5dT kqBX6bxGtynut+hUcwgB902g8h1vLXW8CAlm3ReY9QCHWoVq6W34yFn2YrbppWLfwt5XTEcrE COs+thmN+BBZwDJBF4hl1OH9LFiuvVbekwVOYBQGlPK1OMApIvgwJqMUn/Uhv8SwrLfjVeE4y Pm+WOzDMLqUXDrahaWm5KPCCAr4jDWLOk5oJDgMjZLaomQX1PZfa14gyt3lKuxZENi4Hb3pwB tkmkSnIi0zfRu7FYPJ49nn6lFOGqjGNqu98eOumBWxdnMglt5ned51sA4ofqP0d/0nOMx11/1 bohf+PC4v5akIKHYhalX0jTAj952r8Z09218gDmyjYVP8Ih7XE+l9W1tHQoTUXMdGFKqpAj2b xYSc0xM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.22 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2017 09:37:18 -0000 Hi, on occasion of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864701 "grub-common: grub-mkrescue does nothing, successfully" i wonder whether the reaction of grub-mkrescue on xorriso problems is intended and appropriate. E.g. with: grub-mkrescue -o output.iso SOURCE -------------------------------------------------------------------------- If xorriso is missing, then grub-mkrescue reports grub-mkrescue: warning: Your xorriso doesn't support `--grub2-boot-info'. Some features are disabled. Please use xorriso 1.2.9 or later.. and returns exit value 0. I.e. it does not say that xorriso does not work at all and it does not indicate the failure to its caller. I understand from http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c#n571 that the warning is only emitted if the ISO gets prepared for x86 BIOS. So in other cases the run might be totally silent (did not test). Several distros ship grub-mkrescue in packages which do not mandatorily depend on xorriso. So a clearer message from upstream about the necessity of xorriso seems desirable. -------------------------------------------------------------------------- If xorriso is executable and of sufficient version but the user makes a mistake with grub-mkrescue argument SOURCE (or with some added xorrisofs options), then xorriso aborts with e.g. xorriso : FAILURE : Cannot determine attributes of source file '...' : No such file or directory ... xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' no ISO image emerges but grub-mkrescue exits with value 0. A xorriso batch run returns exit value 5 if it aborts due to the -abort_on threshold. But grub-mkrescue ignores the exit value of xorriso in http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c#n963 -------------------------------------------------------------------------- Have a nice day :) Thomas