From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Date: Wed, 15 Mar 2017 11:10:54 +0100 Message-ID: <2439695.Eb3n5AH02E@diego> References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> <58C90F8B.7070102@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58C90F8B.7070102@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gTWl0dHdvY2gsIDE1LiBNw6RyeiAyMDE3LCAxNzo1NToyMyBDRVQgc2NocmllYiBDaHJpcyBa aG9uZzoKPiBIaSBIZWlrbwo+IAo+IE9uIDAzLzE1LzIwMTcgMDU6MDMgUE0sIEhlaWtvIFN0w7xi bmVyIHdyb3RlOgo+ID4gQW0gTWl0dHdvY2gsIDE1LiBNw6RyeiAyMDE3LCAxNjo0MjozMCBDRVQg c2NocmllYiBDaHJpcyBaaG9uZzoKPiA+PiBGb3IgUkszMzk5LCB0aGUgZ3JmIGNsb2NrIHNob3Vs ZCBiZSBjb250cm9sbGVkIGJ5IGR3LW1pcGktZHNpIGRyaXZlciwKPiA+PiBhZGQgdGhlIGRlc2Ny aXB0aW9uIGZvciB0aGlzIGNsb2NrLgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFpo b25nIDx6eXdAcm9jay1jaGlwcy5jb20+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gICAuLi4vZGV2aWNl dHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dCAg ICAgIAo+ID4+ICAgfCAyCj4gPj4gCj4gPj4gKy0gMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdAo+ID4+IGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvZHdfbWlwaV9kc2lfcm9j a2NoaXAKPiA+PiAudAo+ID4+IHh0Cj4gPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9kd19taXBpX2RzaV9yb2NrY2hpcAo+ID4+IC50Cj4gPj4g eHQgaW5kZXggMTg4ZjZmNy4uN2UxN2E2MCAxMDA2NDQKPiA+PiAtLS0KPiA+PiBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3Jv Y2tjaGlwCj4gPj4gLnQKPiA+PiB4dCArKysKPiA+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwCj4gPj4gLnQK PiA+PiAKPiA+PiB4dCBAQCAtMTAsNyArMTAsNyBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4+ ICAgLSBpbnRlcnJ1cHRzOiBSZXByZXNlbnQgdGhlIGNvbnRyb2xsZXIncyBpbnRlcnJ1cHQgdG8g dGhlIENQVShzKS4KPiA+PiAgIC0gY2xvY2tzLCBjbG9jay1uYW1lczogUGhhbmRsZXMgdG8gdGhl IGNvbnRyb2xsZXIncyBwbGwgcmVmZXJlbmNlCj4gPj4gICAKPiA+PiAgICAgY2xvY2socmVmKSBh bmQgQVBCIGNsb2NrKHBjbGspLiBGb3IgUkszMzk5LCBhIHBoeSBjb25maWcgY2xvY2sKPiA+PiAK PiA+PiAtICAocGh5X2NmZykgaXMgYWRkaXRpb25hbCByZXF1aXJlZC4gQXMgZGVzY3JpYmVkIGlu IFsxXS4KPiA+PiArICAocGh5X2NmZykgYW5kIGEgZ3JmIGNsb2NrKGdyZikgYXJlIGFkZGl0aW9u YWwgcmVxdWlyZWQuIEFzIGRlc2NyaWJlZAo+ID4+IGluCj4gPj4gWzFdLgo+ID4gCj4gPiB5b3Vy ICJncmYiIGNsb2NrIGlzIG9wdGlvbmFsLCBhcyBpdCBpcyBub3QgcHJlc2VudCBvbiBhbGwgc29j cyAobGlrZSB0aGUKPiA+IHJrMzI4OCkgc28gc2hvdWxkIHByb2JhYmx5IG1vdmUgdG8gYSBzZXBh cmF0ZSBzZWN0aW9uIGFuZCBub3QgYmUgaW4gdGhlCj4gPiByZXF1aXJlZCBwcm9wZXJ0aWVzCj4g Cj4gRm9yIFJLMzM5OSwgdGhlIGdyZiBjbG9jayBpcyByZXF1aXJlZCwgYWNjb3JkaW5nIHRvIHRo ZSBhZHZpY2UgcHJvdmlkZWQKPiBieSByb2JbMF0sCj4gcHV0IGl0IGludG8gInJlcXVpcmVkIHBy b3BlcnRpZXMgIiBpcyBiZXR0ZXIuCj4gWzBdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcv cGF0Y2gvOTIyMDE4Ny8KCm9rLCBidXQgaXQgc2hvdWxkIHByb2JhYmx5IGJlIG1hZGUgY2xlYXIs IHRoYXQgdGhpcyBpcyByazMzOTktc3BlY2lmaWMKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Wed, 15 Mar 2017 11:10:54 +0100 Subject: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi In-Reply-To: <58C90F8B.7070102@rock-chips.com> References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> <58C90F8B.7070102@rock-chips.com> Message-ID: <2439695.Eb3n5AH02E@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 15. M?rz 2017, 17:55:23 CET schrieb Chris Zhong: > Hi Heiko > > On 03/15/2017 05:03 PM, Heiko St?bner wrote: > > Am Mittwoch, 15. M?rz 2017, 16:42:30 CET schrieb Chris Zhong: > >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > >> add the description for this clock. > >> > >> Signed-off-by: Chris Zhong > >> --- > >> > >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > >> | 2 > >> > >> +- 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt index 188f6f7..7e17a60 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt +++ > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> > >> xt @@ -10,7 +10,7 @@ Required properties: > >> - interrupts: Represent the controller's interrupt to the CPU(s). > >> - clocks, clock-names: Phandles to the controller's pll reference > >> > >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock > >> > >> - (phy_cfg) is additional required. As described in [1]. > >> + (phy_cfg) and a grf clock(grf) are additional required. As described > >> in > >> [1]. > > > > your "grf" clock is optional, as it is not present on all socs (like the > > rk3288) so should probably move to a separate section and not be in the > > required properties > > For RK3399, the grf clock is required, according to the advice provided > by rob[0], > put it into "required properties " is better. > [0] https://patchwork.kernel.org/patch/9220187/ ok, but it should probably be made clear, that this is rk3399-specific From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbdCOKLL convert rfc822-to-8bit (ORCPT ); Wed, 15 Mar 2017 06:11:11 -0400 Received: from gloria.sntech.de ([95.129.55.99]:44246 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbdCOKLK (ORCPT ); Wed, 15 Mar 2017 06:11:10 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, Mark Yao , David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Date: Wed, 15 Mar 2017 11:10:54 +0100 Message-ID: <2439695.Eb3n5AH02E@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <58C90F8B.7070102@rock-chips.com> References: <1489567352-3333-1-git-send-email-zyw@rock-chips.com> <3304582.Whtjx7Nypf@diego> <58C90F8B.7070102@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 15. März 2017, 17:55:23 CET schrieb Chris Zhong: > Hi Heiko > > On 03/15/2017 05:03 PM, Heiko Stübner wrote: > > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: > >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > >> add the description for this clock. > >> > >> Signed-off-by: Chris Zhong > >> --- > >> > >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > >> | 2 > >> > >> +- 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt index 188f6f7..7e17a60 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt +++ > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> > >> xt @@ -10,7 +10,7 @@ Required properties: > >> - interrupts: Represent the controller's interrupt to the CPU(s). > >> - clocks, clock-names: Phandles to the controller's pll reference > >> > >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock > >> > >> - (phy_cfg) is additional required. As described in [1]. > >> + (phy_cfg) and a grf clock(grf) are additional required. As described > >> in > >> [1]. > > > > your "grf" clock is optional, as it is not present on all socs (like the > > rk3288) so should probably move to a separate section and not be in the > > required properties > > For RK3399, the grf clock is required, according to the advice provided > by rob[0], > put it into "required properties " is better. > [0] https://patchwork.kernel.org/patch/9220187/ ok, but it should probably be made clear, that this is rk3399-specific