From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0CF9CD98CE for ; Mon, 15 Jun 2026 06:57:16 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1338010.1599035 (Exim 4.92) (envelope-from ) id 1wZ1Fp-0002FN-OX; Mon, 15 Jun 2026 06:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1338010.1599035; Mon, 15 Jun 2026 06:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZ1Fp-0002FG-LA; Mon, 15 Jun 2026 06:57:05 +0000 Received: by outflank-mailman (input) for mailman id 1338010; Mon, 15 Jun 2026 06:57:05 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZ1Fp-0002FA-9Z for xen-devel@lists.xenproject.org; Mon, 15 Jun 2026 06:57:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZ1Fo-000iF5-LH for xen-devel@lists.xenproject.org; Mon, 15 Jun 2026 08:57:04 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a2fa233-5cb7-0a2a0a5109dd-0a2a4501e71a-20 for ; Mon, 15 Jun 2026 08:57:04 +0200 Received: from [209.85.128.41] (helo=mail-wm1-f41.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a2fa240-c1f2-0a2a45010019-d1558029c0e2-3 for ; Mon, 15 Jun 2026 08:57:04 +0200 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490c1915793so25857195e9.2 for ; Sun, 14 Jun 2026 23:57:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea4a128csm316467785e9.0.2026.06.14.23.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2026 23:57:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=google header.d=suse.com header.i="@suse.com" header.h="Content-Transfer-Encoding:In-Reply-To:Autocrypt:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781506624; x=1782111424; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lRMPquG8sI7O8264Y7stKa/vThWcl/lWu+nInSfPIGI=; b=f7RATeBXELwNR69nUPs50thoy6fi62KPXyp8ooLg7Nkq/QCPphkLFWQdB1hHsA3pgs BDwuioCOdL1PvBIZ+10XZHNpvk+1XuUOBSYHZqmQ7cJ5VUbuP8kVII7h9xDphtE4HG0S 46sPENrsGr3DHBrJ2eih6f/7JQw9U6PyayenRqQt3SpXyBKfXFgdhyworKqmwg4SYOAP RFkilS1shIuIdPH3yml4q5eU5E2zlu+5wqv1S/tjKc5/ceCNqKRVVvWsumGMFNn6dpGP kpG6M/LP4vxKkG514nn6aDgu9Kw9uYCNLp2fLLzIkMXpG9BPpTDh+nf5/U7YjX96laYz Delg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781506624; x=1782111424; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lRMPquG8sI7O8264Y7stKa/vThWcl/lWu+nInSfPIGI=; b=H6tZidUB1STWyon9//wqj4Eyv6KFaBWgA2yln1meoDWdfagbgA8zxl0rPQ4hgYWJB2 AVhb/gl166HqnA+9aaJBoE8Wxhm6hxy4vBRD5CsVHPPwKi+4uLwUKUd9QcbpeGmT1koC o3Enn1EchpiiXRWzYExlCyqj6mEYVWJb4qVGbt/7AzEE4jSwyqe41PSp9In4PkDDTM24 fIvR43STRit+czI1HlA3sD4ja7JNgbUPPGygiFmvGmyL5Li6GGt4MtKnGNLvLEWuxeur J5IpKOq3hTseDjhaLxluNah3bmfQLoyUlfgMc/pHOZt6ENH+GRVpuecITw8OUz1laHaj 3pDg== X-Forwarded-Encrypted: i=1; AFNElJ+0fuLyvqXoMY1WEjt+uysKl6i58eAdavMHDwjTxDbC3T9uPsqMSR0Nw8Y+9dfaMLIoIkER9Q3zAo0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yyk2J3n7+Z14GJMi8Xou+tZCGKMv4va2lLDkU4X+mTNbElCOnfi iWAjiY8ikWiThKP66jziQGS4U+CEvNMxLiKZABLw+EPo2rQtU0D5xs1mUl501KEPPw== X-Gm-Gg: Acq92OHFfMGLePnEzY621RaNwCKvPS4EN7k4OSuD9XSJZO51fNhSFhj4pcwC1EP/xrE Cm9FZfNNwKoN4BvU4w+qP0/7O63W8/w7lI5NBWONBHMClpA83KdUoHZbKqnUCp5XhftF6gIFMmz 2p1tcUm+rnlQcgSkpJP9cgn+Kh2VV91T4o5aHyAYQcnQyWQlDNcTfFwD8G55s5nicAwIeXLoNTm 7wEFO+zNl7BIV15Ctq7gdOkiccY9+Fxno/GaTSYb8NwcIM+UNafsQUyEKyVnwXO8GAOg+t6IWGL fu3h75PkWwKCKNCKv9527k1jzt9KIddOiCQX6SeZbHLTXbS+W7g/5avW5j3IUpmGsPCgt+Gy7H9 W1ro6eiIX7TnnZhtcaXEN5HmbYUjFffkJMZfng2qMhzbiEVsxPCqA583SyFfnKRKQ0414U4TDRa 2RH0Cf5NsZ1yHJyywWpdhSjQeAjZ4DvFg8ic51pjdHVfzurUp8FWmgomlMagqCMjWLyZIl7gGvh Cv4xADJHo/HcLk= X-Received: by 2002:a05:600c:4f83:b0:492:2c87:3d34 with SMTP id 5b1f17b1804b1-4922c874027mr10516065e9.15.1781506623872; Sun, 14 Jun 2026 23:57:03 -0700 (PDT) Message-ID: <24399462-e83c-40fa-ae90-e66b09b1a461@suse.com> Date: Mon, 15 Jun 2026 08:57:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] xen/sched: Link CPU topology to scheduler To: Hirokazu Takahashi Cc: "Mykyta_Poturai@epam.com" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Dario Faggioli , Juergen Gross , George Dunlap , "xen-devel@lists.xenproject.org" References: <20260610111320.133784-1-taka@valinux.co.jp> <20260610111320.133784-3-taka@valinux.co.jp> <4ad6cce2-c15d-4614-9d73-5ed1354047b8@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1781506624-AF555FF4-4765A661/0/0 X-purgate-type: clean X-purgate-size: 912 On 12.06.2026 21:53, Hirokazu Takahashi wrote: >> On 10.06.2026 13:13, Hirokazu Takahashi wrote: >>> @@ -19,11 +23,17 @@ extern struct cpu_topology *cpu_topology; >>> void map_cpuid_to_node(unsigned int cpuid, struct dt_device_node >> *cpu_node); >>> void dt_init_cpu_topology(void); >>> >>> +#define cpu_to_core(_cpu) (cpu_topology[_cpu].phys_core_id) >>> +#define cpu_to_socket(_cpu) (cpu_topology[_cpu].phys_socket_id) >> >> Please can you avoid introducing new name space violations (identifiers >> with leading underscores should name file scope entities); also again >> below. > > Ok, I will remove the leading underscores from the macro, which were > originally defined in xen/arch/arm/include/asm/processor.h. > Is it okay to leave the macro definitions in x86's > `xen/arch/x86/include/asm/processor.h` untouched? If you have no other need to touch them - of course. Jan