From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754885AbbL3Nv5 (ORCPT ); Wed, 30 Dec 2015 08:51:57 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:62988 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbL3Nv4 (ORCPT ); Wed, 30 Dec 2015 08:51:56 -0500 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: Bamvor Jian Zhang , Sudip Mukherjee , gregkh@linuxfoundation.org, broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl Date: Wed, 30 Dec 2015 14:51:46 +0100 Message-ID: <2440736.t1FM5MM9m8@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5683DB05.7000704@linaro.org> References: <1450346332-31830-1-git-send-email-bamvor.zhangjian@linaro.org> <20151230111648.GA29697@sudip-pc> <5683DB05.7000704@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:oLPfZjuVnxBH96mHM/tUcv4yin4Jos9wDNr20oAOXB16ej/GmOQ ETU9aoeTN0sa/ZRcAFaudZKreeuAKkI2frm0pPyzBVwWVFA50Kpfeat6vOVjR+XsTcPuFzu HMQIz+D7PBWONlHYcQmsVVjfnW/QnLd2J2I88Y+mlhQeUP5I3ZxXBJofhYpWw23xMOCAY4/ NdkNNqGg+PQOzslKBWJMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:aOl7w6FQMDA=:8eABeAVPzSQlR48HH1uXJo 1sEk2Fl9gfV0azKS42UMxVxsr98Na9T+stBTfHQhRJFihGqGiY7onbVL/XPp3CYof5Wxugt8Q bY6GMQpj8v55Haoe/rhthTXM7mT11YcjoruNnwrg3elLeaa/ujf9W4a+x4fvmlViimhhXxY13 UIj4oty7ghYUOAhtaz9Zv5B41/6yfuOubWxSNEpTqoTHpjG29Euta5jpQtbA8Phv7qgCy/E6z sgMHHlSEWD/BJAt+D8YT/dlahiGLVQkLbTX/gj576q6kgGtjfxYYnyTjSg/Yeyuvor9/Rlt62 uJzYDJWgO7tGUyto3HPCzhccyCSeIamqIHRpw4lSafHU8FuVU7/YdQ/QNj7urrf29cfk8x8Fj Oe7MKSEtQ9XOOyaY4YkQE+Kv/hlxf/tq12UPMdNTYB1QVYEWHTZMG3znmQIeBLC+4GK+VDuFp iv6bANSkeF/hqgJ03FblWi5NwdtpK6xZ9H22cbeHU1ws4N4ZhnsWQKgfxanQy2xgoRKWujrYA pnqFVlR/MgN7IpHCQ2PsPat7WLVpQjgMQsNnOBKU9qHWfuCoEmqr4h0XJ0AyDoUqjfDyA34jP X0ZrXvf5ZBVW64ugSTX/1jWS5fksfiiofBKc3SnEDFMF5xuDryV1Qvq/ZSkxlGn2phIUJORdN EWV7D02LiC/KbP1F4DMsM+h7oEWsYBQ8rlSnNzMmbHtpFFXe7RvhjFC42IiqI7TrbuluIu1Uu XvlZRc+AWK6rhHs4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote: > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > index 31bc7b7..9e98d01 100644 > --- a/drivers/char/ppdev.c > +++ b/drivers/char/ppdev.c > @@ -636,7 +636,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > if ((time32[0] < 0) || (time32[1] < 0)) > return -EINVAL; > > - if (copy_to_user(time32, argp, sizeof(time32))) > + if (copy_to_user(argp, time32, sizeof(time32))) > return -EFAULT; > > return 0; > @@ -648,7 +648,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > if ((time64[0] < 0) || (time64[1] < 0)) > return -EINVAL; > > - if (copy_to_user(time64, argp, sizeof(time64))) > + if (copy_to_user(argp, time64, sizeof(time64))) > return -EFAULT; > > return 0; This is something that would be caught by running 'make C=1' with 'sparse' on your patch. Can you try that to see if you introduce any other warnings? I'm guessing it's fine, but it would be nice to confirm. I also send a lot of patches without running sparse and checkpatch first, but it's generally a good idea. Arnd