From: Thomas Monjalon <thomas@monjalon.net>
To: wenxuanx.wu@intel.com
Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, dev@dpdk.org,
david.marchand@redhat.com, Harman Kalra <hkalra@marvell.com>
Subject: Re: [DPDK] /lib/eal: fix failed to stop device monitor error
Date: Sun, 13 Feb 2022 12:29:35 +0100 [thread overview]
Message-ID: <2445962.TLnPLrj5Ze@thomas> (raw)
In-Reply-To: <20220211084131.72606-1-wenxuanx.wu@intel.com>
+Cc Harman, maintainer of interrupt subsystem.
11/02/2022 09:41, wenxuanx.wu@intel.com:
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> The ret value in rte_dev_event_monitor_stop stands for whether the
> monitor has been successfully closed ,and should not bind with
> rte_intr_callback_unregister,so once it goes to the right exit point of
> rte_dev_event_monitor, the ret value should be set to 0.
>
> Also ,the refmonitor count has been carefully evaluated ,the value
> change from 1 to 0 ,so there is no potential memory leak failure.
>
> Fixes: 1fef6ced07f3 ("eal/linux: allow multiple starts of event monitor")
> Cc:stable@intel.com
>
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> ---
> lib/eal/linux/eal_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
> index bde55a3d92..4646e8a550 100644
> --- a/lib/eal/linux/eal_dev.c
> +++ b/lib/eal/linux/eal_dev.c
> @@ -384,6 +384,7 @@ rte_dev_event_monitor_stop(void)
> close(rte_intr_fd_get(intr_handle));
> rte_intr_instance_free(intr_handle);
> intr_handle = NULL;
> + ret = 0;
>
> monitor_refcount--;
>
>
next prev parent reply other threads:[~2022-02-13 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 8:41 [DPDK] /lib/eal: fix failed to stop device monitor error wenxuanx.wu
2022-02-13 11:29 ` Thomas Monjalon [this message]
2022-03-01 9:38 ` Wu, WenxuanX
2022-03-01 9:57 ` David Marchand
2022-03-02 10:53 ` Long Li
2022-03-07 17:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2445962.TLnPLrj5Ze@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenxuanx.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.