All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
	leonro@nvidia.com, jgg@nvidia.com,
	linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
	chuck.lever@oracle.com
Cc: oren@nvidia.com, israelr@nvidia.com, maorg@nvidia.com,
	yishaih@nvidia.com, hch@lst.de, shiraz.saleem@intel.com,
	edumazet@google.com
Subject: Re: [PATCH 1/6] IB/core: add support for draining Shared receive queues
Date: Tue, 18 Jun 2024 09:07:26 -0700	[thread overview]
Message-ID: <244b708e-be75-435a-8b27-c48e976d4cdd@acm.org> (raw)
In-Reply-To: <20240618001034.22681-2-mgurtovoy@nvidia.com>

On 6/17/24 5:10 PM, Max Gurtovoy wrote:
> +	if (wait_for_completion_timeout(&qp->srq_completion, 10 * HZ) > 0) {
> +		while (polled != cq->cqe) {
> +			n = ib_process_cq_direct(cq, cq->cqe - polled);
> +			if (!n)
> +				return;
> +			polled += n;
> +		}
> +	}

Why a hardcoded timeout (10 * HZ) instead of waiting forever?

Thanks,

Bart.



  reply	other threads:[~2024-06-18 16:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  0:10 [PATCH v1 0/6] Last WQE Reached event treatment Max Gurtovoy
2024-06-18  0:10 ` [PATCH 1/6] IB/core: add support for draining Shared receive queues Max Gurtovoy
2024-06-18 16:07   ` Bart Van Assche [this message]
2024-06-19  9:14     ` Sagi Grimberg
2024-06-19 11:12       ` Max Gurtovoy
2024-06-19  9:09   ` Sagi Grimberg
2024-06-19 11:16     ` Max Gurtovoy
2024-06-18  0:10 ` [PATCH 2/6] IB/isert: remove the handling of last WQE reached event Max Gurtovoy
2024-06-19  9:16   ` Sagi Grimberg
2024-06-19 15:25     ` Max Gurtovoy
2024-06-18  0:10 ` [PATCH 3/6] RDMA/srpt: " Max Gurtovoy
2024-06-18 16:08   ` Bart Van Assche
2024-06-18  0:10 ` [PATCH 4/6] nvmet-rdma: " Max Gurtovoy
2024-06-18  0:10 ` [PATCH 5/6] svcrdma: " Max Gurtovoy
2024-06-18 15:12   ` Chuck Lever
2024-06-18  0:10 ` [PATCH 6/6] RDMA/IPoIB: " Max Gurtovoy
2024-06-19  9:18   ` Sagi Grimberg
2024-06-19  9:25     ` Leon Romanovsky
2024-06-23 13:03 ` [PATCH v1 0/6] Last WQE Reached event treatment Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=244b708e-be75-435a-8b27-c48e976d4cdd@acm.org \
    --to=bvanassche@acm.org \
    --cc=chuck.lever@oracle.com \
    --cc=edumazet@google.com \
    --cc=hch@lst.de \
    --cc=israelr@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maorg@nvidia.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=oren@nvidia.com \
    --cc=shiraz.saleem@intel.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.