All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Richard Cheng <icheng@nvidia.com>, akpm@linux-foundation.org
Cc: jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, ljs@kernel.org,
	liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, shuah@kernel.org,
	linux-kselftest@vger.kernel.org, kobak@nvidia.com,
	kaihengf@nvidia.com, newtonl@nvidia.com, kristinc@nvidia.com
Subject: Re: [RFC PATCH 2/2] selftests/mm: Test per-open gup_test pin ownership
Date: Mon, 21 Sep 2026 12:28:47 +0200	[thread overview]
Message-ID: <244ce64d-b7df-4a76-bcf9-effb0c53073d@kernel.org> (raw)
In-Reply-To: <20260921094243.64698-3-icheng@nvidia.com>

On 9/21/26 11:42, Richard Cheng wrote:
> Long-term pin state should be isolated between independently opened
> gup_test file descriptions, while descriptors created with dup() should
> continue to share the state associated with their struct file.
> 
> Add tests using 2 independently opened gup_test descriptors. Verify that
> stopping or closing the second descriptor doesn't disturb the first
> descriptor's pin, that another START on the same descriptor fails with
> EINVAL, and that READ fails with EINVAL after STOP.
> 
> Close the descriptor used by the existing test matrix before running the
> ownership tests. Record whether gup_test was initially available so that
> a later open failure is reported as a failure instead of being hidden as
> a skip.
> 
> Also exercise the shared-file-description case: start a pin through the
> original descriptor, verify that START through a duplicate fails with
> EINVAL, close the original descriptor, and use the duplicate to READ and
> STOP the pin
> 
> Reviewed-by: Koba Ko <kobak@nvidia.com>
> Signed-off-by: Richard Cheng <icheng@nvidia.com>
> ---
>  tools/testing/selftests/mm/gup_longterm.c | 258 +++++++++++++++++++++-
>  1 file changed, 256 insertions(+), 2 deletions(-)

Sorry, we won't be adding tests for gup_test interface functionality. This is a
testing interface.

(I'd be quite surprised if no LLM was inovolved in writing this patch :) )

-- 
Cheers,

David

      reply	other threads:[~2026-09-21 10:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:42 [RFC PATCH 0/2] Fix gup_test long-term pin ownership Richard Cheng
2026-09-21  9:42 ` [RFC PATCH 1/2] mm/gup_test: Track long-term pins per open file Richard Cheng
2026-09-21 10:26   ` David Hildenbrand (Arm)
2026-09-21  9:42 ` [RFC PATCH 2/2] selftests/mm: Test per-open gup_test pin ownership Richard Cheng
2026-09-21 10:28   ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=244ce64d-b7df-4a76-bcf9-effb0c53073d@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=icheng@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=kaihengf@nvidia.com \
    --cc=kobak@nvidia.com \
    --cc=kristinc@nvidia.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=newtonl@nvidia.com \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.