From: Thomas Monjalon <thomas@monjalon.net>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] devtools: ignore new warnings on reported-by tag
Date: Wed, 20 Aug 2025 15:33:00 +0200 [thread overview]
Message-ID: <2450283.yKrmzQ4Hd0@thomas> (raw)
In-Reply-To: <20250820095050.1090859-1-dsosnowski@nvidia.com>
20/08/2025 11:50, Dariusz Sosnowski:
> There were 2 changes introduced in checkpatch.pl script [1][2]
> which verify if Reported-by tag is followed by Link or Closes tag.
> Example of the warning output:
>
> WARNING:BAD_REPORTED_BY_LINK:
> Reported-by: should be immediately followed by Closes:
> with a URL to the report
>
> Original purpose is to link the patch to the mailing list discussion
> and/or a bug report.
>
> Since in DPDK these tags are not used, these warnings are false
> positives and can be ignored in devtools/checkpatches.sh.
We use "Reported-by", it gives credit to people doing this precious work.
But we don't mandate a link for this credit.
> [1]: https://github.com/torvalds/linux/commit/d7f1d71e5ef630ab9e15b5821d297a9e1a5fa1da
> [2]: https://github.com/torvalds/linux/commit/44c31888098a590b8ec5ba37009e5a983f7c4b46
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
> devtools/checkpatches.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 35037aa8f1..8c5b5d1380 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,STRLCPY,\
> PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL,BAD_REPORTED_BY_LINK"
> options="$options $DPDK_CHECKPATCH_OPTIONS"
next prev parent reply other threads:[~2025-08-20 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 9:50 [PATCH] devtools: ignore new warnings on reported-by tag Dariusz Sosnowski
2025-08-20 10:35 ` Bruce Richardson
2025-08-20 13:33 ` Thomas Monjalon [this message]
2025-08-20 13:58 ` Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2450283.yKrmzQ4Hd0@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.