All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Morrissey, Sean" <sean.morrissey@intel.com>,
	"Laatz, Kevin" <kevin.laatz@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
	Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"
Date: Mon, 29 Jul 2019 22:06:27 +0200	[thread overview]
Message-ID: <2451654.9878AJQY2f@xps> (raw)
In-Reply-To: <CAJFAV8x6qo_NgNwMBWfpP1zEAC5hh90O4xR-J3Z88Z5r3stWZQ@mail.gmail.com>

29/07/2019 10:40, David Marchand:
> On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 25/07/2019 10:42, David Marchand:
> > > > > > 24/07/2019 17:20, Sean Morrissey:
> > > > On further investigation, the full fix involves
> > > > a change in the EAL command line parameter handling,
> > > > which is probably too risky for RC3.
> >
> > No way you change the command line parsing,
> > except the rte_option which was created for telemetry.
> > The history of this "simple" feature is already full
> > of hesitations which made me hesitate to merge.
> > Please, don't force me to dig in the code, otherwise
> > I will be tempted to do a big "clean-up".
> >
> > > > This revert will allow telemetry to function again,
> > > > but with the erroneous message still in place.
> > > > We will aim to fix in the next release.
> > >
> > > Might be good to look and revisit the rte_option api.
> 
> The patch on eal did not make any sense.
> I am for reverting it too.

OK, reverted.

Next time I will see a patch for telemetry, I will ask all questions
and will check by myself.



      parent reply	other threads:[~2019-07-29 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 15:20 [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" Sean Morrissey
2019-07-24 15:31 ` Thomas Monjalon
2019-07-24 16:28   ` Morrissey, Sean
2019-07-24 21:34     ` Thomas Monjalon
2019-07-25  8:38       ` Morrissey, Sean
2019-07-25  8:42         ` David Marchand
2019-07-28 19:55           ` Thomas Monjalon
2019-07-29  8:40             ` David Marchand
2019-07-29  9:22               ` Gaëtan Rivet
2019-07-29 20:06               ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2451654.9878AJQY2f@xps \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=kevin.laatz@intel.com \
    --cc=sean.morrissey@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.