From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] Revert "ARM: shmobile: Disallow PINCTRL without GPIOLIB"
Date: Fri, 31 May 2013 07:30:39 +0000 [thread overview]
Message-ID: <2453185.UXGPeICmfe@avalon> (raw)
In-Reply-To: <1369969227-11742-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Simon,
On Friday 31 May 2013 14:40:11 Simon Horman wrote:
> On Fri, May 31, 2013 at 05:00:27AM +0200, Laurent Pinchart wrote:
> > GPIOLIB dependency handling was added to the PINCTRL core by
> >
> > commit 2afe8229687ec24cbc07e78449a588bb8b68f858
> > Author: Haojian Zhuang <haojian.zhuang@linaro.org>
> > Date: Thu Mar 28 07:34:19 2013 +0800
> >
> > pinctrl: core: add dependence of GPIOLIB
> >
> > There is not need to handle that dependency at the SH Mobile level
> > anymore. Revert
> >
> > commit 6722f6cb763203cab775297b6e9d00834af0d6d7
> > Author: Magnus Damm <damm@opensource.se>
> > Date: Mon Mar 18 22:58:18 2013 +0900
> >
> > ARM: shmobile: Disallow PINCTRL without GPIOLIB
> >
> > Modify mach-shmobile to only select PINCTRL in case of
> > ARCH_WANT_OPTIONAL_GPIOLIB is set.
> >
> > This fixes a build error triggered when adding a new SoC
> >
> > lacking GPIO software support (ARCH_WANT_OPTIONAL_GPIOLIB=n):
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > The patch has been tested by hacking arch/arm/mach-shmobile/Kconfig to
> > remove ARCH_WANT_OPTIONAL_GPIOLIB selection from ARCH_EMEV2. The kernel
> > then compiles fine with PINCTRL enabled and GPIOLIB disabled.
>
> Hi Laurent,
>
> could you clarify if this is for v3.11 or v3.10?
No urgency here, v3.11 is fine.
>
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 49d993c..dfb4fee 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -645,7 +645,7 @@ config ARCH_SHMOBILE
> >
> > select MULTI_IRQ_HANDLER
> > select NEED_MACH_MEMORY_H
> > select NO_IOPORT
> >
> > - select PINCTRL if ARCH_WANT_OPTIONAL_GPIOLIB
> > + select PINCTRL
> >
> > select PM_GENERIC_DOMAINS if PM
> > select SPARSE_IRQ
> > help
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-31 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 3:00 [PATCH] Revert "ARM: shmobile: Disallow PINCTRL without GPIOLIB" Laurent Pinchart
2013-05-31 5:40 ` Simon Horman
2013-05-31 7:30 ` Laurent Pinchart [this message]
2013-05-31 7:53 ` Simon Horman
2013-06-04 2:14 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2453185.UXGPeICmfe@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.