From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 600B3606D81B for ; Sat, 7 Nov 2026 14:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=IukngZRw; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=XYuv4fYM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=6yZvYf7M5DZyclCpP+Jl7B8u/UqeZhkcCSFGjt88qCQ=; b=IukngZRwlxpsRTWq2c0XUHwURt 9ocU5ZWr/r+1iqqF30fw4gTT4Wjjnp8d3a3ILPw5uNoKmSOvOaXmrtMSjsN3raKRx8hX6IQA0Yase rZG74xgfXw7QStgLzVCEOZFMy4xjzmtg5pMjAjiZEePPcyUxDSOoCEfqypo6QOVdS0Wj7ylXhiqEs FpHVGXLOsLtB1Y2yddSNXOmJq3n9cpl7qsOtUBNuau0wG2D4Eop/BK+6QQGA6C6G9iJclmhzx+K6H S2MRfZ/XyScqOO+hauy1gIb+aXWHND7lIOP/w2H55Znb/y7E393WR62fPMK5lNBloBC3FLY9IEwIB cSjaPt0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPhk6-0000000Er2l-2PMf; Sat, 07 Nov 2026 14:50:06 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPhk3-0000000Er28-3cG8; Sat, 07 Nov 2026 14:50:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=rCtCLaXuoBajgUckhWEDWeKqUiY5Jp/q685S3dMTOBU=; b=XYuv4fYMGfp8WiLCq7bsTniChM x8V2AxaJTLLbaFlm3r5jQWBGYPawdLNVgYZ3MJX8dPrAcBBZU7fgEAfk+qJ0Jgc94vK6gMgg9HGCa ty3mMgbt1Wl5eUiXOJMA5ZZNq6AcIFaEIO5aMZweUrTusjxTGXtN2IQdnQ1K/c0zaNeEN1y3NA/wv Z2Uc4uXtjeGObyJf+ElqpA5FQci4z8n4oH+1tE6muB/lYxBW5MGNxybGdZJloi110/LC2IGU5yLkN Ew0cFYosZD3ERCzLVZq4r29Mspj9YRYuv2mauBKSy6esUH3tT6nnjaYbw0L69ngw4jSJerd17qZcX EWTDz4cw==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 3/6] powercap: dtpm: Remove duplicate RK3399 CPU hierarchy nodes Date: Sat, 07 Nov 2026 15:49:56 +0100 Message-ID: <2454229.bcXerOTE6V@phil> In-Reply-To: References: X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_065003_928177_506C20F1 X-CRM114-Status: GOOD ( 19.88 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRGllbnN0YWcsIDMuIE5vdmVtYmVyIDIwMjYsIDA1OjQ4OjE3IE1pdHRlbGV1cm9ww6Rpc2No ZSBOb3JtYWx6ZWl0IHNjaHJpZWIgRGFuaWVsIExlemNhbm86Cj4gVGhlIERUUE0gQ1BVIGJhY2tl bmQgcmVnaXN0ZXJzIG9uZSBwb3dlcmNhcCB6b25lIHBlciBjcHVmcmVxIHBvbGljeSwKPiBub3Qg cGVyIENQVS4gT24gUkszMzk5LCBDUFVzIHNoYXJpbmcgdGhlIHNhbWUgY3B1ZnJlcSBwb2xpY3kg dGhlcmVmb3JlCj4gbWFwIHRvIHRoZSBzYW1lIERUUE0gem9uZS4KPiAKPiBSZW1vdmUgdGhlIHJl ZHVuZGFudCBDUFUgbm9kZXMgZnJvbSB0aGUgUkszMzk5IGhpZXJhcmNoeSBhbmQga2VlcCBvbmx5 Cj4gb25lIENQVSBub2RlIHBlciBjcHVmcmVxIHBvbGljeS4gVGhlIGJhY2tlbmQgYWxyZWFkeSBz dXBwcmVzc2VzIGR1cGxpY2F0ZQo+IHJlZ2lzdHJhdGlvbiB0aHJvdWdoIGl0cyBwZXItQ1BVIHN0 YXRlLCBzbyB0aGUgcmVtb3ZlZCBlbnRyaWVzIGFyZQo+IHJlZHVuZGFudCBkZXNjcmlwdGlvbnMg b2YgdGhlIHNhbWUgem9uZXMuIEtlZXAgYm90aCBDUFUgcG9saWN5IGRvbWFpbnMKPiBhbmQgdGhl IEdQVSBpbiB0aGUgaGllcmFyY2h5LCBwcmVwYXJpbmcgZm9yIG9uZSBjcmVhdGVkIHpvbmUgcGVy IGdlbmVyaWMKPiBoaWVyYXJjaHkgbm9kZS4KPiAKPiBBbHNvIGZpeCBpbmRlbnRhdGlvbiBpbiB0 aGUgUm9ja2NoaXAgZGV2aWNlIG1hdGNoIHRhYmxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmll bCBMZXpjYW5vIDxkYW5pZWwubGV6Y2Fub0Bvc3MucXVhbGNvbW0uY29tPgo+IFJldmlld2VkLWJ5 OiBMdWthc3ogTHViYSA8bHVrYXN6Lmx1YmFAYXJtLmNvbT4KPiAtLS0KPiBDaGFuZ2VzIGluIHY1 IChzaW5jZSB2NCk6Cj4gLSBBZGQgUmV2aWV3ZWQtYnkgZnJvbSBMdWthc3ogTHViYTsgbm8gY29k ZSBjaGFuZ2VzLgo+IAo+IENoYW5nZXMgaW4gdjQgKHNpbmNlIHYzKToKPiAtIFJlYmFzZSBvbiB2 Ny4zOyBubyBjb2RlIG9yIGNvbW1pdC1kZXNjcmlwdGlvbiBjaGFuZ2VzLgo+IAo+IENoYW5nZXMg aW4gdjMgKHNpbmNlIHYyKToKPiAtIFJlYmFzZSBvbiB2Ny4zLXJjNy4KPiAtIEZpeCBSb2NrY2hp cCBtYXRjaC10YWJsZSBpbmRlbnRhdGlvbiBoZXJlIHJhdGhlciB0aGFuIGluIHBhdGNoIDEuCj4g LSBDbGFyaWZ5IHRoYXQgdGhlIGV4aXN0aW5nIGJhY2tlbmQgc3VwcHJlc3NlcyBkdXBsaWNhdGUg cmVnaXN0cmF0aW9uLgo+IAo+ICBkcml2ZXJzL3NvYy9yb2NrY2hpcC9kdHBtLmMgfCAyMiArKysr Ky0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDE3 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9yb2NrY2hpcC9kdHBt LmMgYi9kcml2ZXJzL3NvYy9yb2NrY2hpcC9kdHBtLmMKPiBpbmRleCBiMzZkNGY3NTJjMzAuLmU3 MWYzMTVmYmI2YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NvYy9yb2NrY2hpcC9kdHBtLmMKPiAr KysgYi9kcml2ZXJzL3NvYy9yb2NrY2hpcC9kdHBtLmMKPiBAQCAtMjAsMzAgKzIwLDE4IEBAIHN0 YXRpYyBzdHJ1Y3QgZHRwbV9ub2RlIF9faW5pdGRhdGEgcmszMzk5X2hpZXJhcmNoeVtdID0gewo+ ICAJWzJdID0geyAubmFtZSA9ICIvY3B1cy9jcHVAMCIsCj4gIAkJLnR5cGUgPSBEVFBNX05PREVf RFQsCj4gIAkJLnBhcmVudCA9ICZyazMzOTlfaGllcmFyY2h5WzFdIH0sCj4gLQlbM10gPSB7IC5u YW1lID0gIi9jcHVzL2NwdUAxIiwKPiArCVszXSA9IHsgLm5hbWUgPSAiL2NwdXMvY3B1QDEwMCIs Cj4gIAkJLnR5cGUgPSBEVFBNX05PREVfRFQsCj4gIAkJLnBhcmVudCA9ICZyazMzOTlfaGllcmFy Y2h5WzFdIH0sCj4gLQlbNF0gPSB7IC5uYW1lID0gIi9jcHVzL2NwdUAyIiwKPiArCVs0XSA9IHsg Lm5hbWUgPSAiL2dwdUBmZjlhMDAwMCIsCj4gIAkJLnR5cGUgPSBEVFBNX05PREVfRFQsCj4gIAkJ LnBhcmVudCA9ICZyazMzOTlfaGllcmFyY2h5WzFdIH0sCj4gLQlbNV0gPSB7IC5uYW1lID0gIi9j cHVzL2NwdUAzIiwKPiAtCQkudHlwZSA9IERUUE1fTk9ERV9EVCwKPiAtCQkucGFyZW50ID0gJnJr MzM5OV9oaWVyYXJjaHlbMV0gfSwKPiAtCVs2XSA9IHsgLm5hbWUgPSAiL2NwdXMvY3B1QDEwMCIs Cj4gLQkJLnR5cGUgPSBEVFBNX05PREVfRFQsCj4gLQkJLnBhcmVudCA9ICZyazMzOTlfaGllcmFy Y2h5WzFdIH0sCj4gLQlbN10gPSB7IC5uYW1lID0gIi9jcHVzL2NwdUAxMDEiLAo+IC0JCS50eXBl ID0gRFRQTV9OT0RFX0RULAo+IC0JCS5wYXJlbnQgPSAmcmszMzk5X2hpZXJhcmNoeVsxXSB9LAo+ IC0JWzhdID0geyAubmFtZSA9ICIvZ3B1QGZmOWEwMDAwIiwKPiAtCQkudHlwZSA9IERUUE1fTk9E RV9EVCwKPiAtCQkucGFyZW50ID0gJnJrMzM5OV9oaWVyYXJjaHlbMV0gfSwKPiAtCVs5XSA9IHsg Lyogc2VudGluZWwgKi8gfQo+ICsJWzVdID0geyAvKiBzZW50aW5lbCAqLyB9Cj4gIH07Cj4gIAo+ ICBzdGF0aWMgc3RydWN0IG9mX2RldmljZV9pZCBfX2luaXRkYXRhIHJvY2tjaGlwX2R0cG1fbWF0 Y2hfdGFibGVbXSA9IHsKPiAtICAgICAgICB7IC5jb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5 OSIsIC5kYXRhID0gcmszMzk5X2hpZXJhcmNoeSB9LAo+IC0gICAgICAgIHt9LAo+ICsJeyAuY29t cGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTkiLCAuZGF0YSA9IHJrMzM5OV9oaWVyYXJjaHkgfSwK PiArCXt9LAo+ICB9Owo+ICAKPiAgc3RhdGljIGludCBfX2luaXQgcm9ja2NoaXBfZHRwbV9pbml0 KHZvaWQpCgpjaGVja2VkIGFnYWluc3QgdGhlIGNwdSBjbHVzdGVycywgdGhpcyBvZiBjb3Vyc2Ug bG9va3MgY29ycmVjdAoKUmV2aWV3ZWQtYnk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2gu ZGU+CgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpM aW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJv Y2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063005; b=gMkfXDzK2h1JeHMkwgFbATqhJfTHOhRHNThWXQAIl/iOtsPLbPCs7FlEULUB31xUP2HB qxfhi7J0ogGsAoc+DfBBGH6/IE8CeVTey9OkJKPKA/9rw4UThN8LvZdS7ICXBKvkOtYC3 3Nx29PS4fSvj96ibWpjP4abp3ofPgNTvIfeEy5sD9HMZU8axrnpTtb1lEg7w6tUpdz1bY UjOV+TjCurY8K2ErqNSGYcvINJRazSdqzIV1HBQf++tNXMi/TASGYvWyTj9CR/XIBsZ+7 0/YHOfdCFWB3Qg3EO+OZyRVNBWLE/7ZhMAd5j3SU8Qw03o6hZY+sOX39+ehSBeJ0jPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063005; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=rCtCLaXuoBajgUckhWEDWeKqUiY5Jp/q685S3dMTOBU=; b=GYJ/Z1KGPtlq6EI/HxywVoiBfTowY8iF5u1vvR0kCH1PgAFQc5UjZEkbfuJi+qWnUxpz 6n4mpTHVLS0Y+jTcWJtVvj5SEh5Ton4MacRhsKNUQec9SqMEErxtbV0NCHS5OSPY3ebow KSWmc70YmgoGc3kg9/0Qlvyc5K3wtNMktMJHHUw5HKr1hFXbc4Jofj1KcbPPy3ZETnTeQ XkPs9O10kyLw4WZYZdXtQV3FeztYNDIfs8jZC8eg5P0fYYP3/OZKC+2mada0ikXlqD9Wz 4O6LFrwZirlQZlW3nI5smY7O3nzqz5N5AQDr6cJx1JAs1+nIDx67gGN98NFMe9OdXag== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=XYuv4fYM; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68855606A330; Sat, 7 Nov 2026 14:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 68855606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=XYuv4fYM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=rCtCLaXuoBajgUckhWEDWeKqUiY5Jp/q685S3dMTOBU=; b=XYuv4fYMGfp8WiLCq7bsTniChM x8V2AxaJTLLbaFlm3r5jQWBGYPawdLNVgYZ3MJX8dPrAcBBZU7fgEAfk+qJ0Jgc94vK6gMgg9HGCa ty3mMgbt1Wl5eUiXOJMA5ZZNq6AcIFaEIO5aMZweUrTusjxTGXtN2IQdnQ1K/c0zaNeEN1y3NA/wv Z2Uc4uXtjeGObyJf+ElqpA5FQci4z8n4oH+1tE6muB/lYxBW5MGNxybGdZJloi110/LC2IGU5yLkN Ew0cFYosZD3ERCzLVZq4r29Mspj9YRYuv2mauBKSy6esUH3tT6nnjaYbw0L69ngw4jSJerd17qZcX EWTDz4cw==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 3/6] powercap: dtpm: Remove duplicate RK3399 CPU hierarchy nodes Date: Sat, 07 Nov 2026 15:49:56 +0100 Message-ID: <2454229.bcXerOTE6V@phil> In-Reply-To: References: X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Dienstag, 3. November 2026, 05:48:17 Mitteleurop=C3=A4ische Normalzeit s= chrieb Daniel Lezcano: > The DTPM CPU backend registers one powercap zone per cpufreq policy, > not per CPU. On RK3399, CPUs sharing the same cpufreq policy therefore > map to the same DTPM zone. >=20 > Remove the redundant CPU nodes from the RK3399 hierarchy and keep only > one CPU node per cpufreq policy. The backend already suppresses duplicate > registration through its per-CPU state, so the removed entries are > redundant descriptions of the same zones. Keep both CPU policy domains > and the GPU in the hierarchy, preparing for one created zone per generic > hierarchy node. >=20 > Also fix indentation in the Rockchip device match table. >=20 > Signed-off-by: Daniel Lezcano > Reviewed-by: Lukasz Luba > --- > Changes in v5 (since v4): > - Add Reviewed-by from Lukasz Luba; no code changes. >=20 > Changes in v4 (since v3): > - Rebase on v7.3; no code or commit-description changes. >=20 > Changes in v3 (since v2): > - Rebase on v7.3-rc7. > - Fix Rockchip match-table indentation here rather than in patch 1. > - Clarify that the existing backend suppresses duplicate registration. >=20 > drivers/soc/rockchip/dtpm.c | 22 +++++----------------- > 1 file changed, 5 insertions(+), 17 deletions(-) >=20 > diff --git a/drivers/soc/rockchip/dtpm.c b/drivers/soc/rockchip/dtpm.c > index b36d4f752c30..e71f315fbb6b 100644 > --- a/drivers/soc/rockchip/dtpm.c > +++ b/drivers/soc/rockchip/dtpm.c > @@ -20,30 +20,18 @@ static struct dtpm_node __initdata rk3399_hierarchy[]= =3D { > [2] =3D { .name =3D "/cpus/cpu@0", > .type =3D DTPM_NODE_DT, > .parent =3D &rk3399_hierarchy[1] }, > - [3] =3D { .name =3D "/cpus/cpu@1", > + [3] =3D { .name =3D "/cpus/cpu@100", > .type =3D DTPM_NODE_DT, > .parent =3D &rk3399_hierarchy[1] }, > - [4] =3D { .name =3D "/cpus/cpu@2", > + [4] =3D { .name =3D "/gpu@ff9a0000", > .type =3D DTPM_NODE_DT, > .parent =3D &rk3399_hierarchy[1] }, > - [5] =3D { .name =3D "/cpus/cpu@3", > - .type =3D DTPM_NODE_DT, > - .parent =3D &rk3399_hierarchy[1] }, > - [6] =3D { .name =3D "/cpus/cpu@100", > - .type =3D DTPM_NODE_DT, > - .parent =3D &rk3399_hierarchy[1] }, > - [7] =3D { .name =3D "/cpus/cpu@101", > - .type =3D DTPM_NODE_DT, > - .parent =3D &rk3399_hierarchy[1] }, > - [8] =3D { .name =3D "/gpu@ff9a0000", > - .type =3D DTPM_NODE_DT, > - .parent =3D &rk3399_hierarchy[1] }, > - [9] =3D { /* sentinel */ } > + [5] =3D { /* sentinel */ } > }; > =20 > static struct of_device_id __initdata rockchip_dtpm_match_table[] =3D { > - { .compatible =3D "rockchip,rk3399", .data =3D rk3399_hierarchy = }, > - {}, > + { .compatible =3D "rockchip,rk3399", .data =3D rk3399_hierarchy }, > + {}, > }; > =20 > static int __init rockchip_dtpm_init(void) checked against the cpu clusters, this of course looks correct Reviewed-by: Heiko Stuebner