From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/5] gfs2_edit: Fix unaligned accesses due to saved_metablock size
Date: Thu, 12 Jan 2017 11:02:00 -0500 (EST) [thread overview]
Message-ID: <245600883.10033195.1484236920767.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170110143446.14419-6-anprice@redhat.com>
----- Original Message -----
| Each saved block is prefixed by a saved_metablock structure that holds
| its block number and data length. Unfortunately this structure is 10
| bytes in size, which means that storing the metadata header in memory
| immediately following it causes accesses to the header fields to be
| unaligned. This causes testsuite failures on sparc64. Instead, on
| restore, use a separate buffer for the block data to ensure aligned
| accesses to those fields.
|
| Reported-By: Valentin Vidic <Valentin.Vidic@CARNet.hr>
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---
Hi,
ACK
Bob Peterson
Red Hat File Systems
prev parent reply other threads:[~2017-01-12 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:34 [Cluster-devel] [PATCH 0/5] gfs2_edit fixes Andrew Price
2017-01-10 14:34 ` [Cluster-devel] [PATCH 1/5] gfs2_edit savemeta: Factor out the bh saving code Andrew Price
2017-01-12 15:42 ` Bob Peterson
2017-01-10 14:34 ` [Cluster-devel] [PATCH 2/5] gfs2_edit savemeta: Don't read rgrp blocks twice Andrew Price
2017-01-12 15:49 ` Bob Peterson
2017-01-13 14:42 ` Andrew Price
2017-01-13 15:06 ` Bob Peterson
2017-01-10 14:34 ` [Cluster-devel] [PATCH 3/5] gfs2_edit savemeta: Follow lf_next Andrew Price
2017-01-12 15:52 ` Bob Peterson
2017-01-10 14:34 ` [Cluster-devel] [PATCH 4/5] gfs2_edit: Fix unaligned access in restore_init() Andrew Price
2017-01-12 15:58 ` Bob Peterson
2017-01-10 14:34 ` [Cluster-devel] [PATCH 5/5] gfs2_edit: Fix unaligned accesses due to saved_metablock size Andrew Price
2017-01-12 16:02 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=245600883.10033195.1484236920767.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.