From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] ring: enforce reading the tails before ring operations
Date: Sat, 09 Mar 2019 00:18:08 +0100 [thread overview]
Message-ID: <2456717.RLOWIjrx09@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580136556F40@irsmsx105.ger.corp.intel.com>
08/03/2019 16:50, Ananyev, Konstantin:
> 08/03/2019 16:05, Gavin Hu (Arm Technology China):
> > Anyway, on x86, smp_rmb, as a compiler barrier, applies to load/store, not only load/load.
>
> Yes, that's true, but I think that's happened by coincidence,
> not intentionally.
>
> > This is the case also for arm, arm64, ppc32, ppc64.
> > I will submit a patch to expand the definition of this API.
>
> I understand your intention, but that does mean we would also need
> to change not only rte_smp_rmb() but rte_rmb() too (to keep things consistent)?
> That sounds worring.
> Might be better to keep smp_rmb() definition as it is, and introduce new function
> that fits your purposes (smp_rwmb or smp_load_store_barrier)?
How is it managed in other projects?
next prev parent reply other threads:[~2019-03-08 23:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190306114906eucas1p19c2572b1fe777e1eb0ca96d2e47295bd@eucas1p1.samsung.com>
2019-03-06 3:07 ` [PATCH v1] ring: enforce reading the tails before ring operations gavin hu
2019-03-06 11:49 ` [v1] " Ilya Maximets
2019-03-07 6:50 ` Gavin Hu (Arm Technology China)
2019-03-07 6:45 ` [PATCH v2] " gavin hu
2019-03-07 8:52 ` Ilya Maximets
2019-03-07 9:27 ` Gavin Hu (Arm Technology China)
2019-03-07 9:48 ` Ilya Maximets
2019-03-07 10:44 ` Gavin Hu (Arm Technology China)
2019-03-07 11:17 ` Ananyev, Konstantin
2019-03-08 3:21 ` Honnappa Nagarahalli
2019-03-08 5:27 ` Gavin Hu (Arm Technology China)
2019-03-08 16:33 ` Ananyev, Konstantin
2019-03-10 20:47 ` Honnappa Nagarahalli
2019-03-11 13:58 ` Ananyev, Konstantin
2019-03-08 4:23 ` Gavin Hu (Arm Technology China)
2019-03-08 5:06 ` Honnappa Nagarahalli
2019-03-08 12:13 ` Ananyev, Konstantin
2019-03-08 15:05 ` Gavin Hu (Arm Technology China)
2019-03-08 15:50 ` Ananyev, Konstantin
2019-03-08 23:18 ` Thomas Monjalon [this message]
2019-03-08 23:48 ` Honnappa Nagarahalli
2019-03-09 10:28 ` Gavin Hu (Arm Technology China)
2019-03-12 16:58 ` [PATCH v3 0/1] ring: enforce reading the tail before reading ring slots Gavin Hu
2019-03-12 16:58 ` [PATCH v3 1/1] " Gavin Hu
2019-03-13 8:12 ` Nipun Gupta
2019-03-15 13:26 ` Ananyev, Konstantin
2019-03-28 0:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2456717.RLOWIjrx09@xps \
--to=thomas@monjalon.net \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=i.maximets@samsung.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.