From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbbKLKPo (ORCPT ); Thu, 12 Nov 2015 05:15:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46953 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbbKLKPn (ORCPT ); Thu, 12 Nov 2015 05:15:43 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1447282921-16352-1-git-send-email-geert@linux-m68k.org> References: <1447282921-16352-1-git-send-email-geert@linux-m68k.org> To: Geert Uytterhoeven Cc: dhowells@redhat.com, Al Viro , linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24592.1447323339.1@warthog.procyon.org.uk> Date: Thu, 12 Nov 2015 10:15:39 +0000 Message-ID: <24593.1447323339@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geert Uytterhoeven wrote: > - int ret; > + int ret = 0; This isn't quite the right solution. The uninitialised error path needs to set -ENOBUFS. Unfortunately, my compiler doesn't show a warning:-/ David