From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender1.zohomail.com (sender1.zohomail.com [72.5.230.95]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 90113E01480 for ; Tue, 21 May 2013 08:27:08 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to:references:mime-version:content-type; b=QHuMW1i11zdhHzrjRqftPdKt0w7igOTPMpyha4j5994HKOr1Jfcs+FmJHFNyLprYPl6ymROmhOhQ qg0ULOpwiYCBqaz2hZbF6pNB9DWmxRg27raMeR1r7mq91USTl23s Received: from localhost.localdomain (static-217-133-170-65.clienti.tiscali.it [217.133.170.65]) by mx.zohomail.com with SMTPS id 1369150025021792.1058055970842; Tue, 21 May 2013 08:27:05 -0700 (PDT) From: Diego To: Otavio Salvador Date: Tue, 21 May 2013 17:27 +0200 Message-ID: <2460319.8CyPJdQAGk@localhost.localdomain> User-Agent: KMail/4.10.2 (Linux/3.8.12-100.fc17.x86_64; KDE/4.10.2; x86_64; ; ) In-Reply-To: References: <1369144657-4084-1-git-send-email-diego.ml@zoho.com> MIME-Version: 1.0 X-ZohoMailClient: External X-Zoho-Virus-Status: 2 Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-demos][PATCH] vivante-gpu-sdk: Contribute recipe for Vivante GPU Samples X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2013 15:27:08 -0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="ISO-8859-1" In data marted=EC 21 maggio 2013 11:34:54, Otavio Salvador ha scritto: > On Tue, May 21, 2013 at 10:57 AM, Diego Rondini w= rote: > > Initial contribution of a recipe for Vivate GPU Samples from Vivant= e GPU > > Sdk. > >=20 > > Signed-off-by: Diego Rondini >=20 > Please change the commit log to be more assertive; something like: >=20 > --- > vivante-gpu-sdk: Add recipe for GPU samples >=20 > Provides the samples provided by Vivante for use with the GPU. > --- >=20 > Or something like that. >=20 Ack. > > --- > >=20 > > ...ation-of-the-GLES1.1-X11-Samples-in-Yocto.patch | 594 > >=20 > > ++++++++++++++++++++ > >=20 > > .../0002-Don-t-build-missing-samples.patch | 28 + > > .../vivante-gpu-sdk/vivante-gpu-sdk_1.00.bb | 35 ++ > > 3 files changed, 657 insertions(+) > > create mode 100644 > >=20 > > recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0001-Fix-compilati= on-of-t > > he-GLES1.1-X11-Samples-in-Yocto.patch>=20 > > create mode 100644 > >=20 > > recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0002-Don-t-build-m= issing- > > samples.patch>=20 > > create mode 100644 recipes-graphics/vivante-gpu-sdk/ > >=20 > > vivante-gpu-sdk_1.00.bb > >=20 > > diff --git > > a/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0001-Fix-compila= tion-of > > -the-GLES1.1-X11-Samples-in-Yocto.patch > > b/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0001-Fix-compila= tion-o > > f-the-GLES1.1-X11-Samples-in-Yocto.patch new file mode 100644 > > index 0000000..dacfd36 > > --- /dev/null > > +++ > > b/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0001-Fix-compila= tion-of > > -the-GLES1.1-X11-Samples-in-Yocto.patch @@ -0,0 +1,594 @@ > > +From 72ba888f8e33a95343be834d5d9f12ce5d8c00f2 Mon Sep 17 00:00:00 = 2001 > > +From: Diego Rondini > > +Date: Tue, 30 Apr 2013 10:52:25 +0200 > > +Subject: [PATCH 1/2] Fix compilation of the GLES1.1 X11 Samples in= Yocto > > + > > +This commit fixes the following build problems: > > +- gcc 4.7 compatibility (remove unsupported "-Wl" option); > > +- wrong compiler binary name (caused by an overwrite of CC and AR > > variables) > > +- unknown include and library paths (caused by forcing paths when = not > > needed) >=20 > Missed signed-off-by and upstream-status. >=20 Ok, will add. > > +--- > > + Samples/GLES1.1/01_SimpleTriangle/Makefile.x11 | 9 +------= -- > > + Samples/GLES1.1/02_VertexColors/Makefile.x11 | 7 +------= > > + .../GLES1.1/03_VertexTransformation/Makefile.x11 | 7 +------= [snip] > > diff --git > > a/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0002-Don-t-build= -missin > > g-samples.patch > > b/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0002-Don-t-build= -missi > > ng-samples.patch new file mode 100644 > > index 0000000..1503848 > > --- /dev/null > > +++ > > b/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk/0002-Don-t-build= -missin > > g-samples.patch @@ -0,0 +1,28 @@ > > +From 97f3af7a44b41f3e46c54765ba415ba9f511fb81 Mon Sep 17 00:00:00 = 2001 > > +From: Diego Rondini > > +Date: Tue, 30 Apr 2013 12:46:38 +0200 > > +Subject: [PATCH 2/2] Don't build missing samples > > + > > +Samples 18_VertexBufferObjects and 19_Beizer are not included in t= he > > package, so don't try to compile them. >=20 > Missed signed-off-by and upstream-status. >=20 Ok, will add. > > +--- > > + Samples/GLES1.1/Makefile.x11 | 4 +--- > > + 1 file changed, 1 insertion(+), 3 deletions(-) > > + > > +diff --git a/Samples/GLES1.1/Makefile.x11 b/Samples/GLES1.1/Makefi= le.x11 > > +index 003763d..1c95158 100755 > > +--- a/Samples/GLES1.1/Makefile.x11 > > ++++ b/Samples/GLES1.1/Makefile.x11 > > +@@ -17,9 +17,7 @@ SUB_PROJECTS=3D \ > > + 14_ParticlesSpritesAnimation \ > > + 15_ParticleAccelerator \ > > + 16_VertexBufferObjects \ > > +- 17_Beizer \ > > +- 18_VertexBufferObjects \ > > +- 19_Beizer > > ++ 17_Beizer > > + > > + > > + .PHONY: all > > +-- > > +1.7.9.5 > > + > > diff --git > > a/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk_1.00.bbb/recipes= -graph > > ics/vivante-gpu-sdk/ vivante-gpu-sdk_1.00.bb > > new file mode 100644 > > index 0000000..69bcd01 > > --- /dev/null > > +++ b/recipes-graphics/vivante-gpu-sdk/vivante-gpu-sdk_1.00.bb > > @@ -0,0 +1,35 @@ > > +SUMMARY =3D "Vivante GPU SDK Samples" > > +DESCRIPTION =3D "Freescale's adaptation of Jeff Molofee demos" >=20 > Is this description accurate? >=20 These are the first lines of every source file: /* * This code was created by Jeff Molofee '99 * (ported to Linux by Ti Leggett '01) * (ported to i.mx51, i.mx31 and x11 by Freescale '10) * If you've found this code useful, please let him know. * * Visit Jeff at http://nehe.gamedev.net/ * */ I know the description is not the best one can produce, but this is not= an=20 established project, nor a one man/enterprise work. At least the X11 pa= rt is=20 not Vivante's nor Freescale's specific at all. > > +LICENSE =3D "Proprietary" > > +LIC_FILES_CHKSUM =3D "file://COPYING;md5=3Db3ed4253a63ac8555ccab7c= 4c0aa29a1" > > + > > +PR =3D "r0" >=20 > Drop PR assignment. >=20 Ok, will do. > > +inherit fsl-eula-unpack > > + > > +SRC_URI =3D "${FSL_MIRROR}/${PN}-${PV}.bin;fsl-eula=3Dtrue \ > > + > > file://0001-Fix-compilation-of-the-GLES1.1-X11-Samples-in-Yocto.pat= ch;stri > > plevel=3D1 \ > > + file://0002-Don-t-build-missing-samples.patch;striplevel=3D= 1" >=20 > The striplevel 1 is the default so you can remove it. >=20 Ok, will do. > > +SRC_URI[md5sum] =3D "344c9a260b46a00f86eb5cb73bf729e0" > > +SRC_URI[sha256sum] =3D > > "0f0a576ce1a08719ee1018832ae808ee723fad27a534c9739b5feec6d7435c57" > > + > > +S =3D "${WORKDIR}/${PN}-${PV}" > > +GLES11DIR =3D "${S}/Samples/GLES1.1" >=20 > You can avoid this setting: >=20 > WORKDIR =3D "${S}/Samples/GLES1.1" >=20 I'll have multiple "workdirs", as this initial version is just for GLES= 1.1,=20 but Samples folder has three subfolders: GLES1.1 GLES2.0 OpenVG each one has its own Makefile, and no common Makefile. I'm not interest= ed in=20 creating a common Makefile with a patch, as they might even get package= d=20 separately in the future according to chipset support. According to that, would you still use just: WORKDIR =3D "${S}/Samples/GLES1.1" > > +VIVANTE_INSTALL_DIR =3D "/opt/${PN}" >=20 > > +VIVANTE_INSTALL_DEST_DIR =3D "${D}${VIVANTE_INSTALL_DIR}" >=20 >=20 > I'd use these explicitly as the variable name is bigger than the cont= ent of > it ;-) >=20 Shorter code is not necessarily better or clearer code. However if you = want=20 I'll follow your suggestion. >=20 >=20 >=20 > +do_compile () { >=20 > > + cd "${GLES11DIR}" >=20 > This can be removed. >=20 This is related to the multiple subfolders (GLES1.1, GLES2.0, OpenVG) w= hich=20 will come later, so let's discuss the "WORKDIR" issue. > > + oe_runmake -f Makefile.x11 > > +} > > + > > +do_install () { > > + cd "${GLES11DIR}" >=20 > This can be removed. >=20 As above. > > + install -d "${VIVANTE_INSTALL_DEST_DIR}" > > + oe_runmake -f Makefile.x11 install > > + cp -r bin/ "${VIVANTE_INSTALL_DEST_DIR}" >=20 > Uh? make install does not handle this? >=20 This is not in any way an "established project which installs in standa= rd=20 paths". It's more a "bunch of samples patched in the years, started qui= te some=20 time ago, and intended just to be compiled and started locally by the l= earning=20 developer". > > +} > > + > > +FILES_${PN} +=3D "${VIVANTE_INSTALL_DIR}" > > +FILES_${PN}-dbg =3D "${VIVANTE_INSTALL_DIR}/*/*/.debug" Thanks for your review. If you can clear out the WORKDIR vs multiple Ma= kefiles=20 in subdirs issue I'll post the updated patch. Bests, Diego