From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: tiwai@suse.com, perex@perex.cz, amade@asmblr.net,
kuninori.morimoto.gx@renesas.com, linux-sound@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: core: Move all users to deferrable card binding
Date: Fri, 22 May 2026 13:21:29 +0200 [thread overview]
Message-ID: <2460572.Mh6RI2rZIc@steina-w> (raw)
In-Reply-To: <075c095d-c42f-46cc-98aa-b290f25519d2@intel.com>
Am Donnerstag, 21. Mai 2026, 16:41:04 CEST schrieb Cezary Rojewski:
> On 5/21/2026 12:11 PM, Alexander Stein wrote:
> > Am Donnerstag, 21. Mai 2026, 10:13:45 CEST schrieb Cezary Rojewski:
>
> ...
>
> >>>> Now, listing the clocks won't help here unfortunately. The patch works
> >>>> on the component-level, clock details do not interest it. Also, could
> >>>> you specify the scenario? Is just a simple platform boot causing the
> >>>> problem -or- do you perform some specific test steps to reproduce?
> >>>
> >>> There is no specific scenario, just booting the board causes this error
> >>> during probe.
> >> Thank you for the confirmation.
> >>
> >> I've forgotten to mention - please also attach the equivalnet but from
> >> the system running the previous kernel (one that causes no trouble).
> >> Now, would it be possible to receive the excerpts as attachments? The
> >> timestamps are also welcome - in the above snapshop, all of them are cut
> >> off.
> >
> > I stripped the timestamps deliberately, people told me it's just noise.
> > But here we go
>
> ...
> > [ 15.360319] tlv320aic32x4 1-0018: ASoC error (-22): at snd_soc_dai_set_sysclk() on tlv320aic32x4-hifi
> > [ 15.360342] fsl-asoc-card sound: failed to set sysclk in fsl_asoc_card_late_probe
> > [ 15.360360] fsl-asoc-card sound: ASoC error (-22): at snd_soc_card_late_probe() on tqm-tlv320aic32
> > [ 15.558546] snd_soc_core:snd_soc_register_dai: hdmi-audio-codec hdmi-audio-codec.1: ASoC: Registered DAI 'i2s-hifi'
> The framework' behavior looks just fine. I'll need some additional help
> from your side here.
>
> What does -22 from snd_soc_dai_set_sysclk() actually mean here? The
> codec's ->set_sysclk looks as such:
>
> static int aic32x4_set_dai_sysclk(struct snd_soc_dai *codec_dai,
> int clk_id, unsigned int freq, int dir)
> {
> struct snd_soc_component *component = codec_dai->component;
> struct clk *mclk;
> struct clk *pll;
>
> pll = devm_clk_get(component->dev, "pll");
> if (IS_ERR(pll))
> return PTR_ERR(pll);
>
> mclk = clk_get_parent(pll);
>
> return clk_set_rate(mclk, freq);
> }
>
> Do we even get here? If so, does -22 is caused by devm_clk_get(),
> clk_get_parent() or clk_set_rate() ?
We had a debug session and were able locate the cause to the clock tree
configuration in DT (fix about to be sent). AFAICS there is no problem
with this patch, it just uncovers another issue.
Thanks again to Cezary for supporting me pining this down.
best regards
Alexander
> [snip]
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
next prev parent reply other threads:[~2026-05-22 11:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 14:07 [PATCH] ASoC: core: Move all users to deferrable card binding Cezary Rojewski
2026-05-11 1:06 ` Mark Brown
2026-05-11 1:34 ` Kuninori Morimoto
2026-05-12 8:14 ` Rojewski, Cezary
2026-05-20 9:55 ` Alexander Stein
2026-05-20 10:33 ` Cezary Rojewski
2026-05-21 6:42 ` Alexander Stein
2026-05-21 8:13 ` Cezary Rojewski
2026-05-21 10:11 ` Alexander Stein
2026-05-21 14:41 ` Cezary Rojewski
2026-05-21 14:47 ` Alexander Stein
2026-05-22 11:21 ` Alexander Stein [this message]
2026-05-22 10:16 ` Péter Ujfalusi
2026-05-22 14:32 ` Cezary Rojewski
2026-05-22 14:58 ` Mark Brown
2026-05-22 15:08 ` Cezary Rojewski
2026-05-25 12:48 ` Péter Ujfalusi
2026-05-25 15:06 ` Mark Brown
2026-05-26 5:45 ` Péter Ujfalusi
2026-05-26 11:21 ` Péter Ujfalusi
2026-05-26 11:28 ` Péter Ujfalusi
2026-05-26 16:02 ` Mark Brown
2026-05-27 5:22 ` Péter Ujfalusi
2026-05-27 10:35 ` Mark Brown
2026-05-25 10:44 ` Pierre-Louis Bossart
2026-05-25 21:10 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2460572.Mh6RI2rZIc@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.